async work #7554
Closed
async work #7554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
reviewed
Feb 7, 2023
jepler
reviewed
Feb 7, 2023
| } | ||
|
|
||
| pio_clear_instruction_memory(pio); | ||
| *irq_table = m_new_ll(rp2pio_pio_irq_t, NUM_PIO_INTERRUPT_SOURCES); |
There was a problem hiding this comment.
this probably didn't do what you intended. the 2nd argument states whether the object should be allocated in the long-lived portion of the heap. it's not giving you NUM_PIO_INTERRUPT_SOURCES objects of type rp2pio_pio_irq_t.
There was a problem hiding this comment.
Are you sure?
#define m_new_ll(type, num) ((type *)(m_malloc(sizeof(type) * (num), true)))
There was a problem hiding this comment.
yes, you're right after all. I must have looked at a different macro definition.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.