Skip to content

Conversation

tekktrik
Copy link
Member

  • Adds ignore argument for ignoring specific bundles
  • Updates actions to use Node 20
  • Stops dumping the GitHub context, which I believe I read somewhere wasn't advised

@tekktrik tekktrik requested review from jepler and dhalbert February 12, 2024 18:03
@jepler
Copy link
Contributor

jepler commented Feb 12, 2024

What is the motivation for the change? I think I missed seeing context.

Does the release-gh step need the same treatment?

@tekktrik
Copy link
Member Author

No, this actually brings that functionality already in the release-gh action to the build action. The motivation is issues like adafruit/Adafruit_CircuitPython_Typing#36.

@jepler
Copy link
Contributor

jepler commented Feb 13, 2024

Thanks for the clarification!

jepler
jepler previously approved these changes Feb 13, 2024
Copy link
Contributor

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but don't know how to test

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's try it!

@dhalbert dhalbert merged commit 04ef714 into adafruit:main Feb 13, 2024
@tekktrik tekktrik deleted the dev/update branch February 13, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants