-
Notifications
You must be signed in to change notification settings - Fork 103
V3Legacy Driver options creation #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
Wrong issue number but reverted part of the changes for previous commit. New-SeDriverOptions should stick to the minimum, providing an empty shell but anything that need to be changed depending on parameters passed down should be handled by Start-SeXX |
Merged
itfranck
added a commit
that referenced
this issue
Dec 6, 2020
* Start-SeEdgeDriver throw error on launch (#188) * Edge fix + general debug fix * .Where is not a method for CIM Instance object (#190) * Firefox not using the proper DriverOption (#191) * Filter parameter to get-seelement and applied to Get-SeInput (#186 #192 ) Also fixed a logic error with $Value that was used both as a parameter and a variable, which caused issues. * Legacy code removal causing error with screenshots (#187) * Fix - Filter + Filter error message * Select input by attributes fix. * Edge (new) driver option need to be of type ChromeOptions (#195) * Edge driver option fix (#193) * Edge - semi revert (#197) Since Start-SeDriver have priority over options, options should not handle stuff that depends on parameters. * IE fix (#193) * MSEdge Fix (#193) * ErrorAction Stop when MSEdge Service fail to create. * AcceptInsecureCertificates (Firefox, Chrome, Edge) (#189) * #177 Get-SeInput view (initial commit) * V4.0.0-preview2 build * Drivers update * V4.0.0-preview2 changelog * Version update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some of the drivers still have :
in their Start-SeXXDriver.
This should not be there at this point as the function calling them already provide them with a DriverOptions object to be used.
Currently, they ignore the potentially customized DriverOptions and create a new one.
This was observed for Firefox and now in IE.
The text was updated successfully, but these errors were encountered: