Add scroll reach bottom api for lazy loading usage #1824
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roll reached to bottom
qili26
commented
Nov 15, 2019
| @@ -29,4 +29,5 @@ | |||
| .rdg-grid { | |||
| // min-height is here to show the horizontal scrollbar when there are no rows | |||
| min-height: 1px; | |||
| margin-bottom: 8px; | |||
There was a problem hiding this comment.
Add small space between the bottom row and the bottom border, as the editable small square will increase the height size a little bit, so it's better to leave the margin in advance to avoid some randomly bug that a cell cannot be edited.
qili26
commented
Nov 15, 2019
| @@ -110,6 +110,12 @@ export default function Canvas<R, K extends keyof R>({ | |||
| } | |||
| }, [rowHeight, scrollToRowIndex]); | |||
|
|
|||
| useEffect(() => { | |||
| if (scrollTop + clientHeight - rowHeight * rowsCount === 8) { | |||
There was a problem hiding this comment.
8 is corresponding to this line.
qili26
commented
Nov 15, 2019
| @@ -254,6 +254,10 @@ export interface ScrollPosition { | |||
| scrollTop: number; | |||
| } | |||
|
|
|||
| export interface ScrollOption extends ScrollPosition { | |||
| reachedBottom?: boolean; | |||
There was a problem hiding this comment.
We might want to revisit the API name, but I believe this should be a reasonable API.
There was a problem hiding this comment.
Or should I add a stand alone API like onReachedBottom to be explicitly?
|
Why not just surface the scroll event object, then users can just check for themselves: event.target.clientHeight + event.target.scrollTop === event.target.scrollHeight |
|
blocked by #1852 |
|
Superseded by this #1854 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.