use fs.readFile instead of setImmediate #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Collina <[email protected]>
|
@addaleax LMK if you want to switch to another kind of |
addaleax
added a commit
that referenced
this pull request
Aug 19, 2022
Co-authored-by: Matteo Collina <[email protected]> Fixes: #8 Fixes: #9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matteo Collina [email protected]
The solution to the immediate re-entrancy problem is to not use
setImmediateto spin up the event loop. Usingfsis a way to execute something in a different phase of the event loop, so we avoid thesetImmediatere-entrancy issue.Fixes #8