Skip to content
This repository was archived by the owner on Feb 15, 2024. It is now read-only.

Bugfix/reference deserialization #50

Merged
merged 4 commits into from
Jan 26, 2022

Conversation

mjacoby
Copy link
Contributor

@mjacoby mjacoby commented Nov 25, 2021

When de-/serializing instances of Reference, Enums for id and element type wer not de-/serialized according to the conventions (e.g. was ID_SHORT, now IdShort).

Also versioning schema was updated to allow easier deployment of bugfixes by including datamodel not exactly in the same version but >= [major].[minor] which should also include latest bugfixes on model if they should occur.

@mjacoby mjacoby added the bug Something isn't working label Nov 25, 2021
@mjacoby mjacoby marked this pull request as ready for review November 25, 2021 11:14
Copy link
Contributor

@sebbader sebbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me, even though I am hardly competent to judge your fix :-).

Copy link

@arnoweiss arnoweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100% on board, while verbose, the loosely coupled connection between revision and Model version should work fine in practise

@FrankSchnicke FrankSchnicke changed the base branch from main to bugfix/serialization January 25, 2022 07:22
@FrankSchnicke FrankSchnicke merged commit 70244ad into bugfix/serialization Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants