Skip to content

Fix bad return on RequestError #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2021
Merged

Fix bad return on RequestError #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c9987c
Fix bad return on RequestError
vossen-adobe May 7, 2021
f1f4060
fix test
vossen-adobe May 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/test_queries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def test_query_multiple_user_not_found():
with mock.patch("umapi_client.connection.requests.Session.get") as mock_get:
mock_get.return_value = MockResponse(404, text="404 Object not found")
conn = Connection(**mock_connection_params)
assert conn.query_multiple("user") == ([], True)
assert conn.query_multiple("user") == ([], True, 0, 0, 0, 0)


def test_query_multiple_user_paged():
Expand Down Expand Up @@ -230,7 +230,7 @@ def test_query_multiple_usergroup_not_found():
with mock.patch("umapi_client.connection.requests.Session.get") as mock_get:
mock_get.return_value = MockResponse(404, text="404 Object not found")
conn = Connection(**mock_connection_params)
assert conn.query_multiple("user-group") == ([], True)
assert conn.query_multiple("user-group") == ([], True, 0, 0, 0, 0)


def test_query_multiple_usergroup_paged():
Expand Down
2 changes: 1 addition & 1 deletion umapi_client/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ def query_multiple(self, object_type, page=0, url_params=None, query_params=None
if re.result.status_code == 404:
if self.logger: self.logger.debug("Ran %s query: %s %s (0 found)",
object_type, url_params, query_params)
return [], True
return [], True, 0, 0, 0, 0
else:
raise re

Expand Down