Adds missing x-amz-server-side-encryption and x-amz-server-side-encryption-aws-kms-key-id header #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ption-aws-kms-key-id headers to the getObject response
algorban
force-pushed
the
add-missing-encryption-headers
branch
from
d4726d1 to
29e3076
Compare
|
not sure why the CLA-bot does not recognize that @algorban is part of the Adobe organization... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Given PR adds missing
x-amz-server-side-encryptionandx-amz-server-side-encryption-aws-kms-key-idheaders to the getObject and headObject responses.Problem statement: Currently S3Mock doesn't return these headers in the getObject response (and partially returns in the headObject one). This leads to the exception to be thrown during the object integrity validation by AWS SDK while downloading encrypted object via getObject requests as
x-amz-server-side-encryption-aws-kms-key-idheader is used in the SkipMd5CheckStrategy.Without this header object's etag value is compared to the InputStream digest and validation fails as etag of the encrypted object differs from the md5 checksum.
Related Issue
Tasks