This repository was archived by the owner on Sep 2, 2021. It is now read-only.
Removed string_util since is unused #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @ingorichter if you have a bit of time... |
|
LGTM . @ficristo Could you resolve the conflicts, so I could go ahead with the merge? |
ficristo
force-pushed
the
remove-string-util
branch
from
df0ca92 to
4441bd8
Compare
|
I've rebase the patch. |
|
Thanks @ficristo |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the cefclient example the corrispondent methods are in
testrunnerfiles and used only for tests.