Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Conversation

WebsiteDeveloper
Copy link
Contributor

Fix for #3271.

@ghost ghost assigned jbalsas Mar 29, 2013
@jbalsas
Copy link
Contributor

jbalsas commented Mar 29, 2013

@WebsiteDeveloper Changes look good. I just have one concern. If you dig inside Resizer, you'll see that POSITION_BOTTOM and POSITION_LEFT aren't actually implemented (there's currently no use case in Brackets for them).

We probably shouldn't expose them yet, or if we do, we'd probably want to add an error log in makeResizable to warn that this won't work. Of course, a third option is to go ahead and implement it ;)

@redmunds I think you reviewed this back in the day... what do you think?

@redmunds
Copy link
Contributor

I agree that things that have not yet been implemented should not be exposed.

@WebsiteDeveloper
Copy link
Contributor Author

i'll just remove the exports for those and if i have time i'll look at implementing them, and then reexporting ;)

@jbalsas
Copy link
Contributor

jbalsas commented Mar 29, 2013

Looks good! Merging

jbalsas added a commit that referenced this pull request Mar 29, 2013
Exported Resizer DIRECTION_* and POSITION_* constants
@jbalsas jbalsas merged commit c40b3ae into adobe:master Mar 29, 2013
@WebsiteDeveloper WebsiteDeveloper deleted the ResizerConstants branch March 29, 2013 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants