Skip to content

feat: introduce CSS in JS via Linaria #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2019
Merged

Conversation

jednano
Copy link

@jednano jednano commented May 29, 2019

fix #14

I'm not 😍 with the fact that this PR introduces @craco/craco, but until facebook/create-react-app#6303 is addressed, there aren't a lot of options.

This PR is based off of linaria-cra.

Related Issue

#14

Motivation and Context

https://github.com/callstack/linaria/blob/master/docs/BENEFITS.md

How Has This Been Tested?

  • Added a config folder to the app templates and added it to the tests.
  • Updated the Home component in the app templates to use Linaria and tested expected output.
  • Updated the tsx:component sub-generator to use Linaria and tested expected output.
  • Ran yo tsx and then npm run cover to ensure a fresh install still passes tests.
  • Ran npm start on fresh install (works).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality
    to change)

Checklist:

  • I have signed the
    Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jednano jednano added this to the TSX 0.1.0 milestone May 29, 2019
@jednano jednano added the enhancement New feature or request label May 29, 2019
@jednano jednano self-assigned this May 29, 2019
@jednano jednano force-pushed the css-in-js branch 4 times, most recently from 0a3ebc6 to 5524e44 Compare May 29, 2019 22:38
@adobe adobe deleted a comment from codecov bot May 29, 2019
@adobe adobe deleted a comment from codecov bot May 29, 2019
@jednano jednano added the bug Something isn't working label May 29, 2019
@jednano jednano merged commit 4eb1b69 into adobe:master May 29, 2019
@jednano jednano deleted the css-in-js branch May 29, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS in JS
1 participant