Skip to content

Would like to be able to search the docs #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
solimant opened this issue Jun 9, 2021 · 0 comments · Fixed by #3383
Closed

Would like to be able to search the docs #1999

solimant opened this issue Jun 9, 2021 · 0 comments · Fixed by #3383

Comments

@solimant
Copy link
Collaborator

solimant commented Jun 9, 2021

🙋 Documentation Request

Would like to be able to search the docs

🧢 Your Company/Team

Adobe/RSP
@solimant solimant mentioned this issue Jun 14, 2021
Closed
5 tasks
majornista added a commit to majornista/react-spectrum-v3 that referenced this issue Jun 23, 2021
@majornista
fix(adobe#1999): Improve accessibility in DocSearch results
2dbc959 
Update to adobe#2016 to improve accessibility in DocSearch results so that they better implement the WAI-ARIA ComboBox design pattern.

- Fixes a few other docs issues identified with aXe DevTools.
- Fixes a couple console error messages with themeSwitcherButton and hamburgerButton.
@majornista majornista mentioned this issue Jun 23, 2021
Merged
5 tasks
solimant added a commit to solimant/react-spectrum that referenced this issue Aug 12, 2021
@solimant
Merge pull request #1 from majornista/1999
f63fbad 
fix(adobe#1999): Improve accessibility in DocSearch results
majornista added a commit that referenced this issue Aug 2, 2022
@majornista
fix(#1999): refactor to use SearchAutocomplete and v3 of AlgoliaSearc…
23a2196 
…h API
majornista added a commit that referenced this issue Aug 4, 2022
@majornista
fix(#1999): refactor to use SearchAutocomplete and v3 of AlgoliaSearc…
d108be2 
…h API
@majornista majornista mentioned this issue Aug 4, 2022
Merged
12 tasks
majornista added a commit that referenced this issue Aug 5, 2022
@majornista
fix(#1999): links should work regardless of host
982b770
majornista added a commit that referenced this issue Aug 5, 2022
@majornista
fix(#1999): links should work regardless of host
833e3b1
majornista added a commit that referenced this issue Aug 5, 2022
@majornista
fix(#1999): links should work regardless of host
36dad29
majornista added a commit that referenced this issue Aug 5, 2022
@majornista
fix(#1999): links should work regardless of host
b936169
majornista added a commit that referenced this issue Aug 5, 2022
@majornista
fix(#1999): links should work regardless of host (again)
9cce7fe
majornista added a commit that referenced this issue Aug 5, 2022
@majornista
fix(#1999): links should work regardless of host (again again)
11f621d
majornista added a commit that referenced this issue Aug 12, 2022
@majornista
fix(#1999): sanitize text for ListBox items using DOMPurify
21f587b
majornista added a commit that referenced this issue Sep 6, 2022
@majornista
fox(#1999): remove deprecated placeholder attribute
570f289
majornista added a commit that referenced this issue Sep 7, 2022
@majornista
fix(#1999): Organize results to better reflect the sitemap
42e258b
majornista added a commit that referenced this issue Sep 8, 2022
@majornista
fix(#1999): use ThemeProvider, remove console.log
38d3ad6
majornista added a commit that referenced this issue Sep 8, 2022
@majornista
fix(#1999): adjust css so that main scrolls rather than body
a53f849
majornista added a commit that referenced this issue Sep 9, 2022
@majornista
fix(#1999): refactor DocSearch component into separate file
d2c01b3
majornista added a commit that referenced this issue Sep 9, 2022
@majornista
fix(#1999): fix scroll bar positioning on Windows and updateToc
ef14ba1
majornista added a commit that referenced this issue Sep 20, 2022
@majornista
fix(#1999): add "Search by Algolia" logo
aee0c66 
To be in right relations with the DocSearch TOS, https://docsearch.algolia.com/docs/DocSearch-program#how-much-does-it-cost, we should display the "Search by Algolia" logo.
majornista added a commit that referenced this issue Sep 21, 2022
@majornista
fix(#1999): improve vertical alignment of "Search by Algolia" text in…
6f1deae 
… tray
majornista added a commit that referenced this issue Sep 21, 2022
@majornista
fix(#1999): simplify vertical alignment of "Search by Algolia" text
bc059fd
majornista added a commit that referenced this issue Nov 21, 2022
@majornista
fix(#1999): Fix rendering of SearchAutocomplete "No results" option item
67b3898
majornista added a commit that referenced this issue Nov 21, 2022
@majornista
fix(#1999): Prevent AlgoliaSearch logo from rendering twice in listbo…
abfe118 
…x overlay
majornista added a commit that referenced this issue Nov 23, 2022
@majornista
fix(#1999): refine display of search results
302dadc
majornista added a commit that referenced this issue Nov 23, 2022
@majornista
fix(#1999): add indentation to express hierarchy
9b2b7e5 
- clean up commented code
- use a # icon for "in page link" rather than the chain link icon
majornista added a commit that referenced this issue Nov 23, 2022
@majornista
fix(#1999): fix search box width
d5aed9e
majornista added a commit that referenced this issue Nov 29, 2022
@majornista
fix(#1999): fix search autocomplete width for mobile
879a5c0 
improve css selector specificity so that autocomplete width is inherited correctly
majornista added a commit that referenced this issue Nov 29, 2022
@majornista
fix(#1999): fix querySelector for the themeSwitcher after adding search
151c95c
majornista added a commit that referenced this issue Nov 29, 2022
@majornista
fix(#1999): fix search autocomplete width for mobile
daedda9 
Still need !important.
majornista added a commit that referenced this issue Nov 29, 2022
@majornista
fix(#1999): fix search autocomplete width for mobile
9aa2dc4
majornista added a commit that referenced this issue Nov 30, 2022
@majornista
fix(#1999): fix clear button position
a36cf36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@solimant