onKeyDown not working on ComboBox.

[shomitta]

I need to use combobox for "allowsCustomValue", So I need to trigger event whenever a ENTER key is pressed (not on input change/ selection change) & check the TextEdit value at the time of enter & run command accordingly.

OnSelectionChange/ OnInputChange wont be helpful in this case as we have a requirement to trigger event with custom TextEditValue on pressing Enter.

[reidbarber]

If this is something we want to support, we should add props.onKeyDown to chain(...) here:

react-spectrum/packages/@react-aria/combobox/src/useComboBox.ts

Line 164 in e3e6db0

onKeyDown: !isReadOnly && chain(state.isOpen && collectionProps.onKeyDown, onKeyDown),

Seems reasonable, especially since it is listed in the docs.

[LFDanLu]

To be further discussed with the team, initial discussion is leaning towards the approach mentioned above provided that it doesn't break useComboBox's current interactions

[shomitta]

@LFDanLu / @reidbarber By when are we expecting this change to be merged & getting the new build?

[snowystinger]

The fastest way would be to open a PR containing the change and a test

[reidbarber]

Here is a PR for a similar issue that might be helpful for whoever picks up this issue: #2617