Skip to content

Changing locale on ColorArea doesn't change direction thumb moves with home/end key #2921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ktabors opened this issue Mar 4, 2022 · 2 comments
Closed

Changing locale on ColorArea doesn't change direction thumb moves with home/end key #2921

ktabors opened this issue Mar 4, 2022 · 2 comments
Labels
rsp:ColorArea ColorArea component

Comments

@ktabors
Copy link
Member

ktabors commented Mar 4, 2022

🐛 Bug Report

Changing the locale doesn't change the direction that home/end keys move the thumb.

😯 Current Behavior

Selecting a language that is RTL or LTR, and home/end keys both move the same direction. For other components like slider, color slider, most other things the direction changes.

🔦 Context

Noticed this while testing #2888

🧢 Your Company/Team

RSP
@ktabors ktabors added the rsp:ColorArea ColorArea component label Mar 4, 2022
@LFDanLu
Copy link
Member

LFDanLu commented Mar 9, 2022

Note: will need to discuss w/ internationalization team and accessibility to see what the expected behavior is here.

majornista added a commit that referenced this issue Mar 16, 2022
@majornista
fix(#2921): Changing locale on ColorArea doesn't change direction thu…
adbfff9 
…mb moves with home/end key

Removes the special RTL behavior so that reversing the direction of the gradient actually reverses the direction in which Home or End keys adjust the value.
@majornista majornista mentioned this issue Mar 16, 2022
Closed
5 tasks
@majornista
Copy link
Collaborator

Feedback from @rgeraghty on the globalization team:

@majornista it would be better to match orientation for RTL as works with arrows keys as well (which are not just mac specific, windows as well for smaller form keyboards)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
rsp:ColorArea ColorArea component
Projects
None yet
Milestone
No milestone
3 participants
@majornista @ktabors @LFDanLu