Slider accessibility name calculation fixes for Chrome (#1148) #1389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majornista
requested review from
dannify,
devongovett and
snowystinger
as code owners
LFDanLu
previously approved these changes
Dec 17, 2020
There was a problem hiding this comment.
LGTM, confirmed that the calculated accessibility name is "Label [Maximum/Minimum]" for the range slider handles.
Confirmed that normal sliders announced the same in VoiceOver and that the hook slider 3 thumb stories aria-label story announced the thumb letter properly now
devongovett
reviewed
Dec 17, 2020
devongovett
approved these changes
Dec 17, 2020
devongovett
added a commit
that referenced
this pull request
Dec 17, 2020
dannify
added a commit
that referenced
this pull request
Dec 18, 2020
…" (#1397) * Revert "Slider accessibility name calculation fixes for Chrome (#1148) (#1389)" This reverts commit f8e2bee. * Update packages/@react-spectrum/color/test/ColorSlider.test.tsx Co-authored-by: Danni <[email protected]>
majornista
pushed a commit
to majornista/react-spectrum-v3
that referenced
this pull request
Dec 18, 2020
…#1148)" (adobe#1397) * Revert "Slider accessibility name calculation fixes for Chrome (adobe#1148) (adobe#1389)" This reverts commit f8e2bee. * Update packages/@react-spectrum/color/test/ColorSlider.test.tsx Co-authored-by: Danni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #1148 (review) and https://bugs.chromium.org/p/chromium/issues/detail?id=1159567
Closes #1231, relates to #1148. Closes #1148. Closes #1231.
✅ Pull Request Checklist:
🧢 Your Project:
Adobe/accessibility