Component css packages #2
Conversation
packages/@adobe/spectrum-css-temp/components/button/package.json
Outdated
Show resolved
Hide resolved
|
@devongovett I haven't merged any of our changes in their direction or theirs in ours. For components where we made a change, I kept that, for ones we haven't changed yet, i use their directly and when we need to make changes, we'll override it locally at that point As for how to make sure everything is still working, since we don't have chromatic yet, i suppose we'll need to verify manually |
snowystinger
force-pushed
the
component-css-packages
branch
from
1d791f6 to
ba70abc
Compare
| @@ -17,3 +17,4 @@ storybook-static | |||
|
|
|||
| #allow | |||
| !.storybook-v3/lib | |||
| !packages/**/dist | |||
There was a problem hiding this comment.
pay attention, needed for spectrum-css, not necessarily anything else, 🤷♂ ?
|
Build successful! View the storybook |
|
Build successful! View the storybook |
one issue, modals doesn't exist and for some reason lerna won't use ours...
Fix hold affordance class on buttons
tabs are potentially flakey
I hate that I had to use that many eslint ignores... but i didn't know what else to do
|
Build successful! View the storybook |
snowystinger
force-pushed
the
component-css-packages
branch
from
3384a02 to
6b0cbed
Compare
| let scales = getVariableMappings(['large', 'medium']); | ||
| let globals = getVars('packages/@adobe/spectrum-css-temp/vars/spectrum-global.css'); |
There was a problem hiding this comment.
If you're using individually versioned components, you can refer to @spectum-css/vars/dist/spectrum-global.css. It won't be as paired down as the -unique, but it will have all the variables that a newly added component may use. If you use -unique, you'll only ever get the variables used by the versions of the components that are specifically in that bundle release. If you add a new component or update a component to a version greater than what is in the bundle you're referencing, you might have missing variables.
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
Everything should still work as expected and CSS should be pulled from @adobe/spectrum-css unless we're overriding it in which case it should take it locally from @adobe/spectrum-css-temp/components
🧢 Your Team: