Properly update TableView row width when it is the last column remaining #2028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tableview row width was not updating properly when the 2nd to last column was removed because we were not detecting the width change
LFDanLu
requested review from
dannify,
devongovett and
snowystinger
as code owners
LFDanLu
commented
Jun 15, 2021
Comment on lines
+870
to
+871
| // Uses equals rather than pointEquals so that width/height changes are taken into account | ||
| !cur.rect.equals(layoutInfo.rect) || |
There was a problem hiding this comment.
If all columns were removed/hidden except the left most column, the x, y position of the rect doesn't shift but the width changes. Changed to rect.equals instead of rect.pointEquals so that this case is properly captured
|
Build successful! 🎉 |
dannify
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1153
✅ Pull Request Checklist:
📝 Test Instructions:
Go to http://localhost:9003/?path=/story/tableview--hiding-columns
Hide all columns via clicking each checkbox
Hover each row and make sure the highlight extends to the end of the table
🧢 Your Project: