[FOR REVIEW ONLY] Column resizing controlled WIP #2784
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnorth
requested review from
dannify,
devongovett and
snowystinger
as code owners
…rt percentage values for min/max
dnorth
force-pushed
the
columnResizing-controlled
branch
from
86b25dd to
14531b4
Compare
There was a problem hiding this comment.
Strange question, but what are all the Slider changes? i don't see you making use of useSliderThumb, SliderThumb, and useSliderState anywhere outside of their respective packages. Definitely not in any of the Table or Resizer modules.
Looks like prettier maybe got to them? Might help us help you if you can remove noise from the PR, including in the file TableView.tsx, it's very hard to focus on what you're actually doing
|
Good catch @snowystinger . I didn't realize the prettier changes made it through |
|
Deleted the branch which closed this WIP PR. This is not the true code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[THIS PR IS A BROKEN WIP AND IS ONLY MEANT FOR REVIEW/HELP AND NOT MERGING]
We are implementing column resizing for TableView and to follow this spec (#2555) we am implementing a controlled version of this behavior including an onResize callback.
I am running into an error that I don't understand in regards to tablelayout when I try to create a storybook which utilizes this. (Storybook "Resizable columns, controlled")
The error is regarding the virtualizer and so it's extremely hard to debug for someone who is not familiar with it, but I suspect that it might have something to do with the way that the controlled component is being implemented or utilized. But because the error of the Virtualizer is happening i'm not sure how to continue, so I am hoping someone who is more experienced with this codebase can take a look at this and better understand what might be happening.
Thanks in advance!