Skip to content

Fix controlled numberfield blur shows old value quickly #2882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

snowystinger
Copy link
Member

Closes #2870

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Go to NumberField controlled story
Select all the text in the input
Type '1'
Blur
Should no longer see a blur showing the original value before the formatting takes hold

🧢 Your Project:

Sorry, something went wrong.

@adobe-bot
Copy link

Build successful! 🎉

@snowystinger snowystinger added the small review Easy to review PR label Feb 23, 2022
@devongovett devongovett merged commit cc238b6 into main Feb 28, 2022
@devongovett devongovett deleted the fix-old-value-blur-in-numberfield branch February 28, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useNumberField: old value flash after blur in controlled mode
4 participants