Skip to content

RSP-1329 Define Accessibility Spec for Toast #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 12, 2019

Conversation

majornista
Copy link
Collaborator

Closes RSP-1329

✅ Pull Request Checklist:

  • Included link to corresponding Issue RSP-1329.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exist for this component).
  • Looked at the Accessibility Standard and/or talked to @mijordan about Accessibility for this feature.

📝 Test Instructions:

Review Toast Accessibility spec at specs/accessibility/Toast.mdx

🧢 Your Team:

Accessibility

@github-actions
Copy link

Build successful! View the storybook

@github-actions
Copy link

Build successful! View the storybook

@github-actions
Copy link

Build successful! View the storybook

@majornista majornista requested a review from ktabors October 29, 2019 17:19
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Nov 8, 2019

Build successful! View the storybook

@github-actions
Copy link

Build successful! View the storybook

@devongovett devongovett merged commit 459bda7 into master Nov 12, 2019
@devongovett devongovett deleted the RSP-1329-v3-Toast-a11y-spec branch November 12, 2019 00:43
@github-actions
Copy link

Build successful! View the storybook

devongovett pushed a commit that referenced this pull request Jul 25, 2024
* ButtonGroup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants