Removing pageSize from sliderProps #2917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also forcing pageSize to be a multiple of step
|
Build successful! 🎉 |
snowystinger
previously approved these changes
Mar 3, 2022
|
Build successful! 🎉 |
|
Build successful! 🎉 |
LFDanLu
commented
Mar 4, 2022
|
Build successful! 🎉 |
|
Build successful! 🎉 |
snowystinger
previously approved these changes
Mar 4, 2022
LFDanLu
added a commit
that referenced
this pull request
Mar 4, 2022
#2917 removes the pageSize prop from useSliderState so we need to manually override the page size on pageup pagedown
devongovett
previously approved these changes
Mar 4, 2022
5 tasks
memoizing step calc in useSliderState as well. Exposing pageSize and step from useColorSliderState allows us to remove extraneous useKeyboard from useColorSlider that was previously needed for pageUp/Down handling
|
Build successful! 🎉 |
|
Build successful! 🎉 |
snowystinger
approved these changes
Mar 4, 2022
devongovett
approved these changes
Mar 4, 2022
|
Build successful! 🎉 |
|
Build successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For release audit
Also forcing pageSize to be a multiple of step
✅ Pull Request Checklist:
📝 Test Instructions:
Unit test should cover the behavior
The slider "step" story should also display a page step of 10
The slider "minMax" story should display a page step of 4
🧢 Your Project:
RSP