Skip to content

Move color area gradients inside aria hook like other color components #2950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 14, 2022
Merged

Move color area gradients inside aria hook like other color components #2950

merged 3 commits into from
Mar 14, 2022

Conversation

snowystinger
Copy link
Member

@snowystinger snowystinger commented Mar 12, 2022 •
edited
Loading

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Chromatic would catch most of this. But a general cursory once over with actually moving sliders is needed as well. Just make sure the gradients update with the movement

🧢 Your Project:

@adobe-bot
Copy link

Build successful! 🎉

@snowystinger snowystinger added the small review Easy to review PR label Mar 12, 2022
@adobe-bot
Copy link

Build successful! 🎉

@snowystinger snowystinger merged commit 91ca94f into main Mar 14, 2022
@snowystinger snowystinger deleted the colorarea-gradients-inside-aria-hook branch March 14, 2022 17:17
@dannify dannify added release and removed small review Easy to review PR needs testing labels Mar 14, 2022
@dannify dannify removed the release label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

@majornista majornista majornista approved these changes

@dannify dannify dannify approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@snowystinger @adobe-bot @devongovett @majornista @dannify