Skip to content

Conversation

venikx
Copy link

@venikx venikx commented Jul 7, 2022

Suggestion for #1618 (comment)
Would this be a possibiliy to keep the wide types, while still offering a possibility to make them narrower? It also "solves" the issue when HTMLElement being incompatible when react-aria has different @types/react than the application.

📝 Test Instructions:

const Test = (props: { onClose: () => void, isDismissable: boolean, id: string }) => {
  const ref = useRef()
  const { dialogProps, titleProps } = useDialog<HTMLDivElement, HTMLHeadElement>(props, ref);
  // sets it as a more specific element
  // however useDialog(props, ref) also keeps working
  return (
    <div { ...dialogProps } > <h4>Keker < /h4>{props.children}</div >
    )
}

🧢 Your Project:

Private repository

@devongovett devongovett force-pushed the main branch 2 times, most recently from 8cb1a5d to 3013156 Compare July 23, 2024 22:43
@devongovett devongovett force-pushed the main branch 2 times, most recently from a79adcf to 3013156 Compare September 30, 2024 21:00
@devongovett
Copy link
Member

Closing as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants