Badge component #3429
Badge component #3429
Conversation
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
I'm not sure how to apply the theme. Tried using also, dont know why the prop table isn't populating |
|
fixed the prop table issue. only thing left is to figure out how to apply the theme to the new Provider in the side rail. or maybe just go without the Provider? |
|
Build successful! 🎉 |
| @@ -11,17 +11,25 @@ | |||
| */ | |||
|
|
|||
|
|
|||
| import badgeStyles from '@adobe/spectrum-css-temp/components/label/vars.css'; | |||
| import {Badge} from '@react-spectrum/badge'; | |||
There was a problem hiding this comment.
this will need to be temporarily pulled out so we can merge. otherwise, the production docs will try to find this package but it won't be published yet.
| @@ -0,0 +1,20 @@ | |||
| { | |||
| "name": "@react-types/badge", | |||
| "version": "3.0.0", | |||
There was a problem hiding this comment.
should start at "3.0.0-alpha.0"
| --- | ||
| category: Status | ||
| keywords: [badge] | ||
| --- |
There was a problem hiding this comment.
add after_version: 3.0.0 so that this doesn't go out to the prod docs website right away. it would break until we publish the package.
|
Not sure if we should support disabled badges. I am not really sure what the use case is, and since badges don't have any accessibility semantics, this would just be a general contrast violation. Spectrum says:
https://spectrum.adobe.com/page/badge/#Disabled but afaik badges are never interactive. 🤷 |
|
Update: discussed with spectrum. We should remove the disabled state. |
|
Build successful! 🎉 |
Co-authored-by: Devon Govett <[email protected]>
|
Build successful! 🎉 |
|
Build successful! 🎉 |
#1341 - Add badge component
To add in future alphas:
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
Adobe/Quarry