Get rid of dupe id in DatePicker/useDatePicker #4085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teField a date field in a datepicker/rangepicker gets the field props removed from it, but we still need to call useField in useDateField which will complain that there isnt a aria labelledby so we still need to pass the field props
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } |
snowystinger
approved these changes
Feb 19, 2023
reidbarber
approved these changes
Feb 21, 2023
devongovett
pushed a commit
to adobesamr/react-spectrum
that referenced
this pull request
Feb 22, 2023
* Getting rid of duplicated id present in presentational element * generate a separate id instead to avoid useField complaining in useDateField a date field in a datepicker/rangepicker gets the field props removed from it, but we still need to call useField in useDateField which will complain that there isnt a aria labelledby so we still need to pass the field props
dannify
added a commit
that referenced
this pull request
Feb 23, 2023
* Adding parseDuration functionality Adds parseDuration function to internationalized/date package to parse ISO 8601 Duration strings into a DateTimeDuration object * separating parseDuration documentation to separate PR * corrects formatting issues * corrects documentation for parseDuration function * fix deps in @react-types/list (#4073) * fix(#4067): Storybook Provider addon: Express input:checkbox requires id to be labelled by htmlFor prop (#4068) * Explain Proxy in TableView (#4072) Explain proxy usage in TableView * Update lightningcss (#4070) update lightnincss * fix(#4078): MobileComboBox: searchbox should not have aria-expanded property (#4079) * Get rid of dupe id in DatePicker/useDatePicker (#4085) * Getting rid of duplicated id present in presentational element * generate a separate id instead to avoid useField complaining in useDateField a date field in a datepicker/rangepicker gets the field props removed from it, but we still need to call useField in useDateField which will complain that there isnt a aria labelledby so we still need to pass the field props * Code changes from docs-ts branch (#4090) * Add docs to more pages, and small wording updates --------- Co-authored-by: Daniel Lu <[email protected]> Co-authored-by: Danni <[email protected]> Co-authored-by: Reid Barber <[email protected]> Co-authored-by: Michael Jordan <[email protected]> Co-authored-by: Robert Snow <[email protected]> Co-authored-by: Devon Govett <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3969
✅ Pull Request Checklist:
📝 Test Instructions:
Go to the DatePicker stories and make sure the accessiblity tab doesn't warn about duplicate ids. Also check the useDatePicker docs and make sure the presentational field div doesn't have the same id as the group
🧢 Your Project:
RSP