Update RAC Link API #5074
Merged
Update RAC Link API #5074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
devongovett
dismissed
snowystinger’s stale review
The base branch was changed.
devongovett
force-pushed
the
rac-link
branch
from
595ba80 to
7e8cb42
Compare
|
Build successful! 🎉 |
|
## API Changes
unknown top level export { type: 'identifier', name: 'Column' } |
snowystinger
approved these changes
Sep 14, 2023
yihuiliao
approved these changes
Sep 14, 2023
LFDanLu
approved these changes
Sep 15, 2023
There was a problem hiding this comment.
LGTM, will add a PR for the outdated copy in https://reactspectrum.blob.core.windows.net/reactspectrum/7e8cb425b66c1f2cca44be86d67de442de008de3/docs/react-aria/Breadcrumbs.html#link-1 that mentions the cloning
|
Oh good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RSP Component Milestones (view)
Depends on #4993
This updates the RAC
LinkAPI to just havehrefand other link props directly on it rather than cloning its child. With theRouterProvideradded in #4993 this will support client side routers the same way as our other components, meaning there is no need to support wrapping a router Link component.