feat: add support for Devanagari & Bengali decimal numbering systems #6715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently this is being tested by Express g18n team. Will come back with updating all the necessary documentation when it is validated. |
devongovett
force-pushed
the
main
branch
2 times, most recently
from
8cb1a5d to
3013156
Compare
devongovett
force-pushed
the
main
branch
2 times, most recently
from
a79adcf to
3013156
Compare
|
I am marking this as ready for review as it was finally tested by Express g18n team and confirmed that number field works well for Hindi and Bengali keyboards. @majornista I think this PR is affecting your PR: #6520, would you like me to add additional checks to mine? |
snowystinger
reviewed
Nov 6, 2024
Co-authored-by: Robert Snow <[email protected]>
snowystinger
approved these changes
Nov 7, 2024
|
I no longer have the option to add additional reviewers, @snowystinger would you help me ping additional RS members for code review? |
|
Someone else on the team will review it, thank you for your patience |
LFDanLu
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6623
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
Adobe Express