Skip to content

docs: don't use hooks conditionally in docs #7473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

nathanpower
Copy link
Contributor

@nathanpower nathanpower commented Dec 4, 2024

Closes #7432

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

View documentation preview

🧢 Your Project:

N/A

@nathanpower nathanpower changed the title don't use hooks conditionally in docs [docs] don't use hooks conditionally in docs Dec 4, 2024
@nathanpower nathanpower force-pushed the 7432-no-conditional-hook branch from 897636e to f978538 Compare December 4, 2024 20:04
@nathanpower nathanpower force-pushed the 7432-no-conditional-hook branch from f978538 to 304afd1 Compare December 4, 2024 20:13
@yihuiliao yihuiliao changed the title [docs] don't use hooks conditionally in docs docs: don't use hooks conditionally in docs Dec 5, 2024
@yihuiliao yihuiliao added this pull request to the merge queue Dec 5, 2024
Merged via the queue into adobe:main with commit 369e1e7 Dec 5, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad coding practice in the example
3 participants