fix: Remove onTouchEnd handler in iOS usePreventScroll #7479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trying to interact with the table view in v3, specifically the many items story, the table immediately stops scrolling when I lift my finger and fires a selection on the row, which was not my intent. |
|
That story is not in a dialog so I don't think it would be affected by the change here? |
ugh... hit with the ios 18 bug, it's working just fine in v3 and is already existing in s2 |
snowystinger
approved these changes
Dec 5, 2024
LFDanLu
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7131
See explanation of the issue: #7131 (comment)
I can't reproduce the original issue that the touchend handler was added for described in the comments anymore. Maybe fixed in newer iOS versions. The onFocus handler seems to be sufficient now.