fix(scrollIntoView): respect scroll padding #7484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffijoe
force-pushed
the
main
branch
2 times, most recently
from
82cbe9a to
15ff57f
Compare
devongovett
reviewed
Dec 7, 2024
devongovett
approved these changes
Dec 7, 2024
snowystinger
reviewed
Dec 8, 2024
| let scrollPaddingRightNumber = parseInt(scrollPaddingRight, 10) || 0; | ||
| let scrollPaddingLeftNumber = parseInt(scrollPaddingLeft, 10) || 0; | ||
|
|
||
| if (offsetX <= x + scrollPaddingLeftNumber) { |
There was a problem hiding this comment.
why isn't this one if (offsetX <= borderAdjustedX + scrollPaddingLeftNumber) {? or why isn't line 61 just y instead of borderAdjustedY?
There was a problem hiding this comment.
I couldn't tell you - the original expression used x instead of borderAdjustedX, so I kept it the same. Do you want me to change it?
There was a problem hiding this comment.
no worries, it's not a change from existing behaviour as you pointed out, I just don't recall why one was changed but not the other and hoped you might have some insight.
There was a problem hiding this comment.
To me it looks like it could have been an oversight in the original implementation. I'm happy to make the change if we all agree?
snowystinger
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7037
📝 Test Instructions:
I've added a new story
MenuScrollPaddingExample.Here's a video showing the fixed behavior. Menus don't have footers so I had to add a
divoutside with absolute positioning to demo the scroll bottom also working.scroll-padding-fixed-encoded.mp4