Skip to content

fix: CardView skeleton loaders #8610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

fix: CardView skeleton loaders #8610

merged 1 commit into from
Jul 22, 2025

Conversation

devongovett
Copy link
Member

Test instructions:

  1. Check that the skeleton appears in the loading and loadingMore states. Especially when the last row of real cards fills the whole row. There should be an extra row of skeletons at the bottom.
  2. Check that the empty state example still displays when the loading state is set.

@rspbot
Copy link

rspbot commented Jul 22, 2025

Build successful! 🎉

reidbarber
reidbarber approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devongovett devongovett added this pull request to the merge queue Jul 22, 2025
Merged via the queue into main with commit c845dea Jul 22, 2025
33 checks passed
@devongovett devongovett deleted the cardview-loading-fix branch July 22, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbarber reidbarber reidbarber approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devongovett @rspbot @reidbarber @LFDanLu