Fix double open menu #925
Merged
Fix double open menu #925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves useInteractOutside to fire on mouse down instead of on up, this means menus won't reopen after they've been closed by the blur It also takes advantage of shouldCloseOnInteractOutside, which lets us detect if the the interaction was on the trigger, which will automatically toggle the menu when clicked. If we couldn't filter that event out, then the menu would just be closed from outside interaction and toggled open again immediately cleans up trigger toggle state so it always uses the latest state
|
Build successful! 🎉 |
|
Build successful! 🎉 |
5 tasks
devongovett
added a commit
that referenced
this pull request
Aug 17, 2020
This reverts commit 5098714.
devongovett
added a commit
that referenced
this pull request
Aug 18, 2020
snowystinger
added a commit
that referenced
this pull request
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #850
This moves useInteractOutside to fire on mouse down instead of on up, this means menus won't reopen after they've been closed by the blur
It also takes advantage of shouldCloseOnInteractOutside, which lets us detect if the the interaction was on the trigger, which will automatically toggle the menu when clicked. If we couldn't filter that event out, then the menu would just be closed from outside interaction and toggled open again immediately
cleans up trigger toggle state so it always uses the latest state
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: