Skip to content

Slider handle's active style doesn't match Spectrum spec #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mischnic opened this issue Sep 23, 2020 · 0 comments · Fixed by #967
Closed

Slider handle's active style doesn't match Spectrum spec #966

mischnic opened this issue Sep 23, 2020 · 0 comments · Fixed by #967
Labels
bug Results from a bug in the CSS implementation size-3 M ~18-30hrs; moderate effort or complexity, several work days needed. sync to jira These will be pushed into adobe internal jira

Comments

@mischnic
Copy link
Contributor

mischnic commented Sep 23, 2020 •
edited by adobe-spectrum-bot
Loading

Description

The Slider component's active style of the handle doesn't match the mockups in the Spectrum XD file.

Steps to reproduce

  1. https://opensource.adobe.com/spectrum-css/slider.html
  2. Drag a slider
  3. The handle should have a thicker border when dragging/clicking.

Expected behavior (when clicking/dragging)

Bildschirmfoto 2020-09-23 um 10 56 02

Current behavior (when clicking/dragging)

Bildschirmfoto 2020-09-23 um 11 03 05

Environment

  • Spectrum CSS version: 74000c8
  • Browser(s) and OS(s): 85.0.4183.102, macOS 10.15

Additional context

Trying to upstream this to minimize changes in the CSS "fork" in the React Spectrum repo: adobe/react-spectrum#1083

synced to jira: https://jira.corp.adobe.com/browse/SDS-7660
@mischnic mischnic added the bug Results from a bug in the CSS implementation label Sep 23, 2020
This was referenced Sep 23, 2020
Merged
Merged
@misterbrownlee misterbrownlee added sync to jira These will be pushed into adobe internal jira size-3 M ~18-30hrs; moderate effort or complexity, several work days needed. labels Sep 25, 2020
GarthDB pushed a commit that referenced this issue Sep 30, 2020
@mischnic
fix: slider remove cursor pointer and reenable active style (#967)
8311089 
fix: reenable active style for Slider closes #965, closes #966

fix: remove pointer cursor for Slider

BREAKING CHANGE: update Slider JS to always show active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Results from a bug in the CSS implementation size-3 M ~18-30hrs; moderate effort or complexity, several work days needed. sync to jira These will be pushed into adobe internal jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Slider: remove cursor: pointer and reenable active style mischnic/spectrum-css
2 participants
@misterbrownlee @mischnic