-
Notifications
You must be signed in to change notification settings - Fork 202
fix(search): change keyfocus border to gray-800 #3658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: df67f34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🚀 Deployed on https://pr-3658--spectrum-css.netlify.app |
File metricsSummaryTotal size: 2.24 MB*
search
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
@@ -20,5 +20,6 @@ | |||
--spectrum-search-background-color-disabled: var(--spectrum-disabled-background-color); | |||
--spectrum-search-border-color-disabled: var(--spectrum-disabled-background-color); | |||
--spectrum-search-background-color: var(--spectrum-gray-50); | |||
--spectrum-search-border-color-key-focus: var(--spectrum-gray-900); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does express pulls in this file or from index.css?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, express imports the spectrum.css file and will inherit changes made in Spectrum legacy. Therefore if S1 has no regressions, we probably shouldn't expect to see any in Express, although it never hurts to check!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I went through Express as well, and things continue to look as they were. 👍
Just wanted to double check on the S2 colors- the border colors for the default & hover states in the search field shouldn't have changed correct? I'm seeing gray-500 and gray-600, which I believe is correct, but the validation says they should be gray-300 and gray-400 (which are S2 colors). Let me know, and then I'm happy to approve!
Oh gosh I'm sorry! Yes I had the wrong colors in the validation. S2 spec says |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
94b6905
to
df67f34
Compare
Description
This ticket relates to S2 Foundations Fast Follows for Search. In design verification, it was determined that the border color should be adjusted to
gray-800
in order to match the design spec for Textfield. This PR makes this change so that we can release a new version of search for adobe/spectrum-web-components#5157SWC-576
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
gray-800
/rgb(41, 41, 41)
on key-focus or mouse focus (without mouse hovering on the input)gray-900
/rgb(19, 19, 19)
for focus + hover (either mouse focus or keyfocus) border colorgray-500
/rgb(143, 143, 143)
for defaultgray-600
/rgb(113, 113, 113)
for hovergray-500
/rgb(144, 144, 144)
for defaultgray-600
/rgb(109, 109, 109)
for hovergray-800
/rgb(34, 34, 34)
for mouse focus only (not hover)gray-900
/rgb(0, 0, 0)
for key-focus (only)gray-900
/rgb(0, 0, 0)
for focus + hoverRegression testing
Validate:
Screenshots
To-do list