feat(alert dialog): S2 migration

[cdransf]

Description

CSS-1017 + CSS-1133

This migrates the alert dialog component to the latest Spectrum 2 designs. Custom properties have been remapped and added per the design specification.

The icon in the dialog header has been moved from the right side to the left.

The dialog divider has been removed.

Primary button style has been updated to filled.

Multiple variants are now supported:

• Confirmation
• Information
• Destructive
• Warning (with AlertDiamond icon)
• Error (with AlertTriangle icon)

Dialog buttons may be displayed either horizontally or vertically.

Removed custom properties

--spectrum-alert-dialog-body-font-size
--spectrum-alert-dialog-description-to-buttons
--spectrum-alert-dialog-divider-to-description
--spectrum-alert-dialog-padding
--spectrum-alert-dialog-title-size
--spectrum-alert-dialog-title-to-divider
--spectrum-alert-dialog-title-to-icon

New custom properties

--spectrum-alert-dialog-background-color
--spectrum-alert-dialog-corner-radius
--spectrum-alert-dialog-description-to-button-group
--spectrum-alert-dialog-edge-to-content
--spectrum-alert-dialog-minimum-title-to-icon
--spectrum-alert-dialog-title-to-description

Removed mods

--mod-alert-dialog-body-font-size
--mod-alert-dialog-description-to-buttons
--mod-alert-dialog-divider-to-description
--mod-alert-dialog-padding
--mod-alert-dialog-title-to-divider
--mod-alert-dialog-title-to-icon

New mods

--mod-alert-dialog-background-color
--mod-alert-dialog-corner-radius
--mod-alert-dialog-description-size
--mod-alert-dialog-description-to-button-group
--mod-alert-dialog-edge-to-content
--mod-alert-dialog-minimum-title-to-icon
--mod-alert-dialog-title-to-description

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

1. The documentation pages for at least two other components are still loading, including:

• The pages render correctly, are accessible, and are responsive.

2. If components have been modified, VRTs have been run on this branch:

• VRTs have been run and looked at.
• Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

• I have read the contribution guidelines.
• I have updated relevant storybook stories and templates.
• I have tested these changes in Windows High Contrast mode.
• If my change impacts other components, I have tested to make sure they don't break.
• If my change impacts documentation, I have updated the documentation accordingly.
• ✨ This pull request is ready to merge. ✨

[changeset-bot]

🦋 Changeset detected

Latest commit: bd46f2b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@spectrum-css/alertdialog	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

🚀 Deployed on https://pr-3725--spectrum-css.netlify.app

[github-actions]

File metrics

Summary

Total size: 1.41 MB^*
Total change (Δ): 🟢 ⬇ 0.28 KB (-0.02%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package	Size	Minified	Gzipped	Δ
alertdialog	5.50 KB	5.25 KB	1.25 KB	🔴 ⬆ 0.41 KB

File change details

alertdialog

Filename	Head	Minified	Gzipped	Compared to base
index.css	5.50 KB	5.25 KB	1.25 KB	🔴 ⬆ 0.41 KB
metadata.json	3.40 KB	-	-	🔴 ⬆ 0.31 KB

tokens

Filename	Head	Minified	Gzipped	Compared to base
css/dark-vars.css	46.16 KB	-	-	-
css/global-vars.css	78.26 KB	-	-	-
css/index.css	252.91 KB	-	-	🟢 ⬇ 0.14 KB
css/large-vars.css	41.97 KB	-	-	🟢 ⬇ 0.07 KB
css/light-vars.css	46.16 KB	-	-	-
css/medium-vars.css	42.10 KB	-	-	🟢 ⬇ 0.07 KB
json/tokens.json	396.47 KB	-	-	-

* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

[marissahuysentruyt]

Sorry it took me longer than I meant to get a review done! I do have some questions for you, and found a few small changes.

• Tokens are looking really great. The only one I didn't see in the CSS was alert-dialog-top-to-alert-icon. I'm assuming we've left it out because we have a flex/align-items center now on that heading container, or is there a reason?

And finally- There's a customModalStyles arg being passed to the Template() function. Is that necessary? That wasn't anything you added, I just happened to notice it. Feel free to keep it if we don't really know what it does!

[marissahuysentruyt]

I think we can safely delete this entirely. The --mod-buttongroup-justify-content at line 44 is already set to flex-end, so when I tested deleting this selector, it was already justified this way.

[cdransf]

Hmm, these styles result in the vertical button group being right aligned within the alert — with those removed they're still displayed vertically but are left-aligned within the dialog. ✨

[marissahuysentruyt]

This is related to the title font size token I just mentioned as well. Maybe it's worth an ask, just to make sure.

[cdransf]

Good catch! We had --spectrum-alert-dialog-description-font-size available, so I aliased it...

--spectrum-alert-dialog-description-content-size: var(--spectrum-alert-dialog-description-font-size);

...(--spectrum-alert-dialog-description-size is the name of another token) and applied it:

font-size: var(--mod-alert-dialog-description-content-size, var(--spectrum-alert-dialog-description-content-size)); ✨