Skip to content

Conversation

castastrophe
Copy link
Collaborator

Description

After discussion with the team, we're going to remove the commons package which houses our button and overlay extends. For now, we have hardcoded the shared code into each component and will explore optimizations in the future if needed. This should result in no changes to the compiled output so I did not include a changeset for this update.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@castastrophe castastrophe self-assigned this Sep 18, 2025
@castastrophe castastrophe added size-3 M ~18-30hrs; moderate effort or complexity, several work days needed. build Issues associated with the build process; often a refactor ready-for-review low priority Not a critical update or fix; can be deprioritized if necessary S2 Spectrum 2 deprecation Flag PRs or issues with this to indicate a component is being deprecated. labels Sep 18, 2025
Copy link

changeset-bot bot commented Sep 18, 2025

⚠️ No Changeset found

Latest commit: 72ec6b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 18, 2025

📚 Branch preview

PR #4242 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-4242/index.html.

Copy link
Contributor

github-actions bot commented Sep 18, 2025

File metrics

Summary

Total size: 1.44 MB*
No change in file sizes

Package Size Minified Gzipped
actionbutton 23.66 KB 22.61 KB 2.97 KB
button 28.85 KB 27.51 KB 3.43 KB
closebutton 9.94 KB 9.42 KB 1.79 KB
logicbutton 9.26 KB 8.79 KB 1.68 KB
picker 25.72 KB 24.61 KB 3.23 KB
popover 16.42 KB 15.85 KB 2.00 KB
tooltip 28.63 KB 27.54 KB 2.92 KB

File change details

actionbutton

Filename Head Minified Gzipped Compared to base
index.css 23.66 KB 22.61 KB 2.97 KB 🟢 ⬇ 0.17 KB
metadata.json 10.19 KB - - 🟢 ⬇ 0.07 KB

button

Filename Head Minified Gzipped Compared to base
index.css 28.85 KB 27.51 KB 3.43 KB 🟢 ⬇ 0.57 KB
metadata.json 11.42 KB - - 🟢 ⬇ 0.07 KB

closebutton

Filename Head Minified Gzipped Compared to base
index.css 9.94 KB 9.42 KB 1.79 KB 🟢 ⬇ 0.51 KB
metadata.json 4.57 KB - - 🟢 ⬇ 0.09 KB

logicbutton

Filename Head Minified Gzipped Compared to base
index.css 9.26 KB 8.79 KB 1.68 KB 🟢 ⬇ 0.14 KB
metadata.json 4.27 KB - - 🟢 ⬇ 0.07 KB

picker

Filename Head Minified Gzipped Compared to base
index.css 25.72 KB 24.61 KB 3.23 KB 🟢 ⬇ 0.46 KB
metadata.json 13.11 KB - - 🟢 ⬇ 0.04 KB

popover

Filename Head Minified Gzipped Compared to base
index.css 16.42 KB 15.85 KB 2.00 KB 🟢 ⬇ 0.02 KB
metadata.json 7.30 KB - - -

tooltip

Filename Head Minified Gzipped Compared to base
index.css 28.63 KB 27.54 KB 2.92 KB 🟢 ⬇ 0.02 KB
metadata.json 16.84 KB - - -
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@castastrophe castastrophe added the run_vrt For use on PRs looking to kick off VRT label Sep 19, 2025
@castastrophe castastrophe merged commit 9601a89 into spectrum-two Sep 19, 2025
29 of 37 checks passed
@castastrophe castastrophe deleted the castastrophe/feat-remove-commons-abstractions branch September 19, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues associated with the build process; often a refactor deprecation Flag PRs or issues with this to indicate a component is being deprecated. low priority Not a critical update or fix; can be deprioritized if necessary ready-for-review run_vrt For use on PRs looking to kick off VRT S2 Spectrum 2 size-3 M ~18-30hrs; moderate effort or complexity, several work days needed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants