Skip to content

[Bug]: Dialog close event timing change breaks applications expecting immediate event dispatch #5650

@Rajdeepc

Description

@Rajdeepc

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

Dialog

Library version

1.0.3

Expected behavior

SWC dialogs actually have two distinct events for different purposes:

  • close event - Should indicate the start of dialog closing (immediate)
  • sp-closed event - should indicate the completion of dialog closing (after animations)

Actual behavior

close event indicates the start of dialog close instead of end

Screenshots

No response

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to https://stackblitz.com/edit/vitejs-vite-vuew3kbr?file=src%2Fmy-element.ts
  2. Add a close event on Dialog
  3. console logs the two events

Sample code or abstract reproduction which illustrates the problem

#4937

Severity

SEV 2

Logs taken while reproducing problem

No response

Would you like to track this issue in Jira?

  • Yes, please tell me the ticket number!

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions