Skip to content

Ruben/phase 0 clean #5643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 38 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
b781c08
chore: clean up files
rubencarvalho Jul 29, 2025
8ace404
chore: revert README
rubencarvalho Jul 29, 2025
9a73140
chore: add lint-staged to root
rubencarvalho Jul 29, 2025
f301c56
chore: run constraints fix
rubencarvalho Jul 29, 2025
d4cab6a
chore: add commitlint to root
rubencarvalho Jul 29, 2025
5880b0e
chore: move patch package to root
rubencarvalho Jul 29, 2025
6951f31
chore: fix circleCI paths
rubencarvalho Jul 29, 2025
bb41ec1
chore: fix circleCI commands
rubencarvalho Jul 29, 2025
aa6e3bd
chore: create baseline
rubencarvalho Jul 29, 2025
94fd87f
chore: skip cache restore on circleci
rubencarvalho Jul 29, 2025
08c3425
chore: lets see circle ci vrts lets see
rubencarvalho Jul 29, 2025
d88857d
chore: create review site, will it work now
rubencarvalho Jul 29, 2025
60253f6
chore: add commands back in
rubencarvalho Jul 29, 2025
037c062
chore: don't update baselines
rubencarvalho Jul 29, 2025
2a7d49d
chore: update golden images cache
rubencarvalho Jul 29, 2025
7bef2f9
chore: revert to base path without first-gen prefix
rubencarvalho Jul 29, 2025
a600d98
chore: need to cd to first gen
rubencarvalho Jul 29, 2025
2d1a15b
chore: pull main
rubencarvalho Jul 30, 2025
5e2b6a1
chore: update golden image cache
rubencarvalho Jul 30, 2025
9e4938b
chore: restore all caches
rubencarvalho Jul 30, 2025
349196f
chore: fix coveralls
rubencarvalho Jul 30, 2025
bc575a3
chore: fix docs workflow
rubencarvalho Jul 30, 2025
36712ed
chore: fix tachometer paths
rubencarvalho Jul 30, 2025
416b5e8
chore: fix storybook deployment and prettier
rubencarvalho Jul 30, 2025
4400f65
chore: fix storybook deployment
rubencarvalho Jul 30, 2025
464b8d9
chore: add workdir to lint
rubencarvalho Jul 30, 2025
a4611b3
chore: revert workdir
rubencarvalho Jul 30, 2025
9ba3bcc
chore: fix gitignore and eslint notice path
rubencarvalho Jul 30, 2025
01440dd
chore: fix docs build css and ts paths
rubencarvalho Jul 30, 2025
b501b4c
chore: update eslintrc notice template file path
rubencarvalho Jul 30, 2025
c8d37db
chore: make absolute paths for all eslintrc
rubencarvalho Jul 30, 2025
4658adc
chore: add build:eleventy as a dependency of build
rubencarvalho Jul 30, 2025
012cb47
chore: cleanup some documentation remains in root and update gitignore
rubencarvalho Jul 30, 2025
0d2406d
chore: fix gitignore to exclude broadly caught files
rubencarvalho Jul 30, 2025
523bd7a
chore: clean root-level projects
rubencarvalho Jul 30, 2025
bb04b3c
chore: remove netlify remnants
rubencarvalho Jul 30, 2025
f185bf2
chore: put workdir in eslint task
rubencarvalho Jul 30, 2025
8ddc834
chore: fix paths for urls-smoke-test
rubencarvalho Jul 30, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
62 changes: 32 additions & 30 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ parameters:
# 3. Commit this change to the PR branch where the changes exist.
current_golden_images_hash:
type: string
default: dd2217ab088b6a78c6d95aa4751396726f24fa0f
default: 2a7d49df098157aab00237bd12d4a77a5ee8aa8e
wireit_cache_name:
type: string
default: wireit
commands:
install-azcopy:
description: 'Install AzCopy and set up authentication'
description: "Install AzCopy and set up authentication"
steps:
- run:
when: always
Expand All @@ -51,20 +51,20 @@ commands:
downstream:
steps:
- checkout
# - restore_cache:
# keys:
# - v4c-dependencies-{{ arch }}-{{ checksum "yarn.lock" }}
# - restore_cache:
# keys:
# - v4b-<< pipeline.parameters.wireit_cache_name >>-{{ arch }}-{{ checksum "package.json" }}-
- restore_cache:
keys:
- v4c-dependencies-{{ arch }}-{{ checksum "yarn.lock" }}
- restore_cache:
keys:
- v4b-<< pipeline.parameters.wireit_cache_name >>-{{ arch }}-{{ checksum "first-gen/package.json" }}-
- run:
name: Installing Dependencies
command: |
corepack enable
yarn --immutable
- run:
name: Build the project
command: yarn build
command: cd first-gen && yarn build

- save_cache:
paths:
Expand All @@ -73,8 +73,8 @@ commands:
key: v4c-dependencies-{{ arch }}-{{ checksum "yarn.lock" }}
- save_cache:
paths:
- .wireit
key: v4b-wireit-{{ arch }}-{{ checksum "package.json" }}-{{ epoch }}
- first-gen/.wireit
key: v4b-wireit-{{ arch }}-{{ checksum "first-gen/package.json" }}-{{ epoch }}
- attach_workspace:
at: /
run-regressions:
Expand Down Expand Up @@ -102,7 +102,7 @@ commands:
when: always
name: VRT Run
command: |
yarn test:ci --config web-test-runner.config.vrt.js --group vrt-<< parameters.regression_system >>-<< parameters.regression_color >>-<< parameters.regression_scale >>-<< parameters.regression_dir >>
cd first-gen && yarn test:ci --config web-test-runner.config.vrt.js --group vrt-<< parameters.regression_system >>-<< parameters.regression_color >>-<< parameters.regression_scale >>-<< parameters.regression_dir >>
# store results and artifacts before rearranging things for the new cache.
- store_test_results:
path: /root/project/results/
Expand All @@ -124,8 +124,7 @@ commands:
name: Create review site
command: |
branch=$(git symbolic-ref --short HEAD)
node test/visual/review.js --branch=$branch --commit=<< pipeline.git.revision >> --system="<< parameters.regression_system >> << parameters.regression_color >> << parameters.regression_scale >> << parameters.regression_dir >>"
yarn rollup -c test/visual/rollup.config.js
cd first-gen && node test/visual/review.js --branch=$branch --commit=<< pipeline.git.revision >> --system="<< parameters.regression_system >> << parameters.regression_color >> << parameters.regression_scale >> << parameters.regression_dir >>" && yarn rollup -c test/visual/rollup.config.js
- install-azcopy
- run:
when: always
Expand Down Expand Up @@ -172,7 +171,7 @@ commands:
combination="<< parameters.regression_system >>-<< parameters.regression_color >>-<< parameters.regression_scale >>-<< parameters.regression_dir >>"

# Prepare files for deployment
cp projects/documentation/content/favicon.ico test/visual/ || echo "Failed to copy favicon"
cp first-gen/projects/documentation/content/favicon.ico test/visual/ || echo "Failed to copy favicon"

# Upload VRT results to Azure Blob Storage
echo "Uploading VRT results to ${PR_HASH}/${combination}/"
Expand Down Expand Up @@ -212,11 +211,11 @@ jobs:
- downstream
- run:
name: Run unit tests
command: yarn test:ci --config web-test-runner.config.ci-chromium.js --group no-memory-ci --coverage
command: cd first-gen && yarn test:ci --config web-test-runner.config.ci-chromium.js --group no-memory-ci --coverage
- store_test_results:
path: /root/project/results/
path: /root/project/first-gen/results/
- store_artifacts:
path: coverage
path: first-gen/coverage

test-chromium-memory:
executor: node
Expand All @@ -225,7 +224,7 @@ jobs:
- downstream
- run:
name: Run memory tests
command: yarn test:ci --config web-test-runner.config.ci-chromium.js --group memory-ci
command: cd first-gen && yarn test:ci --config web-test-runner.config.ci-chromium.js --group memory-ci
- store_test_results:
path: /root/project/results/

Expand All @@ -238,6 +237,7 @@ jobs:
- run:
name: Run tests
command: |
cd first-gen
TEST=$(circleci tests glob packages/*/test/*.test.js | circleci tests split --split-by=timings)
yarn test:start --files $TEST --config web-test-runner.config.ci-firefox.js --group unit-ci
- store_test_results:
Expand All @@ -252,6 +252,7 @@ jobs:
- run:
name: Run tests
command: |
cd first-gen
TEST=$(circleci tests glob packages/*/test/*.test.js | circleci tests split --split-by=timings)
yarn test:start --files $TEST --config web-test-runner.config.ci-webkit.js --group unit-ci
- store_test_results:
Expand All @@ -276,33 +277,33 @@ jobs:
- downstream
- run:
name: Generate Custom Elements Manifest
command: yarn docs:analyze
command: cd first-gen && yarn docs:analyze
- run:
name: Move CEM to Storybook directory
command: cp projects/documentation/custom-elements.json storybook/
command: cp first-gen/projects/documentation/custom-elements.json first-gen/storybook/
- run:
name: Build documentation with path prefix
command: echo "SWC_DIR=beta/docs" >> $BASH_ENV
- run:
name: Build documentation
command: yarn docs:build
command: cd first-gen && yarn docs:build
- run:
name: Build Storybook
command: yarn storybook:build
command: cd first-gen && yarn storybook:build
- install-azcopy
- run:
name: Deploy Beta Documentation to Azure Blob Storage
command: |
# Upload documentation to beta path
echo "Uploading documentation to beta/docs/"
azcopy copy "projects/documentation/dist/*" \
azcopy copy "first-gen/projects/documentation/dist/*" \
"https://swcpreviews.blob.core.windows.net/\$web/beta/docs/" \
--recursive \
--from-to LocalBlob

# Upload Storybook to beta path
echo "Uploading Storybook to beta/docs/storybook/"
azcopy copy "storybook-static/*" \
azcopy copy "first-gen/storybook-static/*" \
"https://swcpreviews.blob.core.windows.net/\$web/beta/docs/storybook/" \
--recursive \
--from-to LocalBlob
Expand All @@ -325,12 +326,14 @@ jobs:
- v2-golden-images-main-hcm-
- run:
name: Count baseline images
command: find test/visual/screenshots-baseline -type f | wc -l > count_start.txt
command: |
mkdir -p test/visual/screenshots-baseline
find test/visual/screenshots-baseline -type f | wc -l > count_start.txt
- run:
when: always
name: VRT Run
command: |
yarn test:ci --config web-test-runner.config.vrt.js --group vrt-hcm
cd first-gen && yarn test:ci --config web-test-runner.config.vrt.js --group vrt-hcm --update-visual-baseline
# store results and artifacts before rearranging things for the new cache.
- store_test_results:
path: /root/project/results/
Expand All @@ -352,8 +355,7 @@ jobs:
name: Create review site
command: |
branch=$(git symbolic-ref --short HEAD)
node test/visual/review.js --branch=$branch --commit=<< pipeline.git.revision >> --system="hcm"
yarn rollup -c test/visual/rollup.config.js
cd first-gen && node test/visual/review.js --branch=$branch --commit=<< pipeline.git.revision >> --system="hcm" && yarn rollup -c test/visual/rollup.config.js
- install-azcopy
- run:
when: always
Expand Down Expand Up @@ -397,7 +399,7 @@ jobs:
fi

# Prepare files for deployment
cp projects/documentation/content/favicon.ico test/visual/
cp first-gen/projects/documentation/content/favicon.ico test/visual/

# Upload HCM VRT results to Azure Blob Storage
echo "Uploading HCM VRT to ${PR_HASH}/hcm/"
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/browser-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,22 +45,22 @@ jobs:
echo "Checking Chrome version..."
google-chrome --version
echo "Checking tachometer chromedriver version..."
yarn tachometer --version
cd first-gen && yarn tachometer --version

- name: Tachometer the changed packages
run: yarn test:changed --browser=${{ matrix.browser }}
run: cd first-gen && yarn test:changed --browser=${{ matrix.browser }}

- name: Create a dummy file to ensure at least one results file exists
run: touch tachometer.${{ matrix.browser }}-ran.txt
run: touch first-gen/tachometer.${{ matrix.browser }}-ran.txt

- name: Archive ${{ matrix.browser }} tachometer results
id: upload-artifact
uses: actions/upload-artifact@v4
with:
name: tachometer-results-${{ matrix.browser }}
path: |
tach-results.${{ matrix.browser }}.*.json
tachometer.${{ matrix.browser }}-ran.txt
first-gen/tach-results.${{ matrix.browser }}.*.json
first-gen/tachometer.${{ matrix.browser }}-ran.txt

comment-performance:
name: Comment tachometer performance results
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/coveralls.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ jobs:
uses: ./.github/actions/setup-job

- name: Install Playwright
run: yarn playwright install --with-deps
run: cd first-gen && yarn playwright install --with-deps

- name: Run unit tests with coverage
run: yarn test:ci --config web-test-runner.config.ci-chromium.js --group coveralls-ci --coverage
run: cd first-gen && yarn test:ci --config web-test-runner.config.ci-chromium.js --group coveralls-ci --coverage
continue-on-error: true

- name: Upload coverage to Coveralls
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -122,4 +122,5 @@ jobs:
level: error
reporter: github-pr-review
filter_mode: diff_context
workdir: first-gen
eslint_flags: '${{ needs.changed_files.outputs.eslint_added_files }} ${{ needs.changed_files.outputs.eslint_modified_files }}'
15 changes: 7 additions & 8 deletions .github/workflows/preview-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,23 +64,22 @@ jobs:
run: yarn install --immutable

- name: Build
run: yarn build
run: cd first-gen && yarn build

- name: Generate Custom Elements Manifest
run: yarn docs:analyze
run: cd first-gen && yarn docs:analyze

- name: Move CEM to Storybook directory
run: cp projects/documentation/custom-elements.json storybook/
run: cp first-gen/projects/documentation/custom-elements.json first-gen/storybook/

- name: Build documentation with path prefix
env:
SWC_DIR: ${{ steps.pr_hash.outputs.hash }}/docs
run: |
cd projects/documentation
yarn build
cd first-gen/projects/documentation && yarn build

- name: Build Storybook
run: yarn storybook:build
run: cd first-gen && yarn storybook:build

## --- DEPLOY TO AZURE BLOB STORAGE --- ##
- name: Setup AzCopy
Expand All @@ -93,14 +92,14 @@ jobs:
run: |
# Upload documentation
echo "Uploading documentation to ${PR_HASH}/docs/"
azcopy copy "projects/documentation/dist/*" \
azcopy copy "first-gen/projects/documentation/dist/*" \
"https://swcpreviews.blob.core.windows.net/\$web/${PR_HASH}/docs/" \
--recursive \
--from-to LocalBlob

# Upload Storybook
echo "Uploading Storybook to ${PR_HASH}/docs/storybook/"
azcopy copy "storybook-static/*" \
azcopy copy "first-gen/storybook-static/*" \
"https://swcpreviews.blob.core.windows.net/\$web/${PR_HASH}/docs/storybook/" \
--recursive \
--from-to LocalBlob
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/urls-smoke-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,10 @@ jobs:
uses: ./.github/actions/setup-job

- name: Install Playwright Browsers
run: yarn playwright install --with-deps
run: cd first-gen && yarn playwright install --with-deps

- name: Run Playwright tests
run: yarn playwright test projects/documentation/e2e/published.spec.ts
run: cd first-gen && yarn playwright test projects/documentation/e2e/published.spec.ts
env:
DOC_PREVIEW_URL: ${{ needs.wait-for-deployment.outputs.doc_url }}
SWC_DIR: ${{ needs.wait-for-deployment.outputs.swc_dir }}
Expand Down
Loading
Loading