-
Notifications
You must be signed in to change notification settings - Fork 233
docs: textfield-based component analysis docs #5741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 2nd-gen-component-analysis
Are you sure you want to change the base?
docs: textfield-based component analysis docs #5741
Conversation
|
830facd to
2c217ea
Compare
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this to hopefully provide some context!
|
|
||
| ### The bigger picture | ||
|
|
||
| When an SWC developer picks up Spectrum 2 implementation work, this documentation provides: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, maybe:
| When an SWC developer picks up Spectrum 2 implementation work, this documentation provides: | |
| When Spectrum web engineer picks up next-gen implementation work, this documentation provides: |
|
|
||
| ### Why we do this analysis | ||
|
|
||
| The migration roadmap addresses a critical need in the Spectrum 2 development process: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use "next-gen" rather than "Spectrum 2" anytime we're talking about SWC development? Maybe even in a couple of places above this?
| The migration roadmap addresses a critical need in the Spectrum 2 development process: | |
| The migration roadmap addresses a critical need in the next-gen development process: |
|
|
||
| The migration roadmap addresses a critical need in the Spectrum 2 development process: | ||
|
|
||
| - **Development roadmap**: Provides clear guidance for building 2nd generation web components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
next-gen? 2nd gen?
| The analysis surfaces: | ||
|
|
||
| - **Missing from WC**: CSS features without web component equivalents | ||
| - **Missing from CSS**: Web component features without CSS support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not super relevant, I've been removing these as I see them, so might remove this here as well.
| ### For SWC developers | ||
|
|
||
| 1. **Start here**: Review the component's migration roadmap document | ||
| 2. **Check specifications**: Understand all CSS selectors and SWC features | ||
| 3. **Review DOM changes**: Identify structural changes needed in render methods | ||
| 4. **Analyze mapping table**: Find features that need implementation or removal | ||
| 5. **Read summary**: Get focused overview of required changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, do we want this?
| ## Current components | ||
|
|
||
| The following components have migration documentation: | ||
|
|
||
| - Alert Banner (`alert-banner.md`) | ||
| - [Add other completed components here] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably will take this out because maintaining it wouldn't be very fun.
Description
Creates AI-generated migration documentation to analyze component differences to guide SWC migration to S2, with human vetting. The documentation serves as a bridge between the migrated Spectrum 2 CSS work and the corresponding web components, in order to help engineers understand what needs to be implemented, updated, or aligned between the two systems to guide the development of 2nd generation web components.
This batch is for the barebones components: Textfield/Textarea, Number field, Search, and Color field (which does not exist in CSS or S2 design spec)
Motivation and context
Related issue(s)
SWC-1208
Screenshots (if appropriate)
Author's checklist
I have added automated tests to cover my changes.I have included a well-written changeset if my change needs to be published.Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Documentation Quality
Cross-Reference Accuracy
metadata.jsonfilesDevice review