Skip to content

Conversation

rise-erpelding
Copy link
Collaborator

@rise-erpelding rise-erpelding commented Sep 18, 2025

Description

Creates AI-generated migration documentation to analyze component differences to guide SWC migration to S2, with human vetting. The documentation serves as a bridge between the migrated Spectrum 2 CSS work and the corresponding web components, in order to help engineers understand what needs to be implemented, updated, or aligned between the two systems to guide the development of 2nd generation web components.

This batch is for the barebones components: Textfield/Textarea, Number field, Search, and Color field (which does not exist in CSS or S2 design spec)

Motivation and context

  • Clear development roadmap: Provides comprehensive feature gap analysis for building 2nd generation web components
  • Implementation requirements: Identifies all features and capabilities that need to be implemented to match Spectrum 2 CSS and design specs
  • Breaking change transparency: Establishes implementation requirements and design changes that may lead to breaking changes and/or API changes for the next major version
  • Adoption planning: Enables developers and consuming teams to plan for 2nd gen web component adoption and understand migration effort required

Related issue(s)

SWC-1208

Screenshots (if appropriate)


Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

Documentation Quality

  • All files follow template structure with proper collapsible sections
  • CSS => SWC mapping tables use correct status values
  • Summary sections are concise and actionable
  • No broken markdown syntax

Cross-Reference Accuracy

  • CSS selectors match actual metadata.json files
  • SWC attributes match actual TypeScript source files
  • DOM structure comparisons match template files
  • Implementation gaps are complete and accurate

Device review

  • Did it pass in Desktop?
  • Did it pass in (emulated) Mobile?
  • Did it pass in (emulated) iPad?

@rise-erpelding rise-erpelding requested a review from a team as a code owner September 18, 2025 15:45
Copy link

changeset-bot bot commented Sep 18, 2025

⚠️ No Changeset found

Latest commit: 80b94b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rise-erpelding rise-erpelding force-pushed the rise-erpelding/swc-1208-component-analysis-docs branch from 830facd to 2c217ea Compare September 18, 2025 15:48
@rise-erpelding rise-erpelding self-assigned this Sep 18, 2025
Copy link
Contributor

github-actions bot commented Sep 18, 2025

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5741

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link
Contributor

Tachometer results

Currently, no packages are changed by this PR...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this to hopefully provide some context!


### The bigger picture

When an SWC developer picks up Spectrum 2 implementation work, this documentation provides:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, maybe:

Suggested change
When an SWC developer picks up Spectrum 2 implementation work, this documentation provides:
When Spectrum web engineer picks up next-gen implementation work, this documentation provides:


### Why we do this analysis

The migration roadmap addresses a critical need in the Spectrum 2 development process:
Copy link
Collaborator Author

@rise-erpelding rise-erpelding Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use "next-gen" rather than "Spectrum 2" anytime we're talking about SWC development? Maybe even in a couple of places above this?

Suggested change
The migration roadmap addresses a critical need in the Spectrum 2 development process:
The migration roadmap addresses a critical need in the next-gen development process:


The migration roadmap addresses a critical need in the Spectrum 2 development process:

- **Development roadmap**: Provides clear guidance for building 2nd generation web components
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next-gen? 2nd gen?

The analysis surfaces:

- **Missing from WC**: CSS features without web component equivalents
- **Missing from CSS**: Web component features without CSS support
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not super relevant, I've been removing these as I see them, so might remove this here as well.

Comment on lines +72 to +78
### For SWC developers

1. **Start here**: Review the component's migration roadmap document
2. **Check specifications**: Understand all CSS selectors and SWC features
3. **Review DOM changes**: Identify structural changes needed in render methods
4. **Analyze mapping table**: Find features that need implementation or removal
5. **Read summary**: Get focused overview of required changes
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, do we want this?

Comment on lines +162 to +167
## Current components

The following components have migration documentation:

- Alert Banner (`alert-banner.md`)
- [Add other completed components here]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably will take this out because maintaining it wouldn't be very fun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant