Skip to content

Conversation

castastrophe
Copy link
Contributor

@castastrophe castastrophe commented Sep 19, 2025

Description

This change pins package dependencies across the entire Spectrum Web Components monorepo to ensure consistent and reproducible builds. The update affects 25 package.json files and the yarn.lock file, standardizing dependency versions across all packages and tools.

Note: pinned versions may be minor or patch versions larger than the original. This is because our lockfile was consuming higher versions than we had listed due to our caret approach. I've gone through and tried to map the updated versions to the original lockfile as much as possible.

Motivation and context

Pinning dependencies is essential for:

  • Ensuring reproducible builds across different environments
  • Preventing unexpected breaking changes from dependency updates
  • Maintaining consistent behavior across all packages in the monorepo
  • Improving security by controlling exactly which versions are used
  • Facilitating easier debugging when issues arise

Related issue(s)

  • fixes [SWC-1243]

Screenshots (if appropriate)

N/A - This is a dependency management change without visual changes.

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

Manual review test cases

  • All packages build successfully with pinned dependencies

    1. Go to root directory
    2. Run yarn install to install pinned dependencies
    3. Expect all packages to install without conflicts
  • Build system works with pinned dependencies

    1. Run yarn build
    2. Verify all packages build successfully
    3. Expect no build errors related to dependency conflicts
  • Tests pass with pinned dependencies

    1. Run yarn test
    2. Verify all tests pass
    3. Expect no test failures related to dependency changes

@castastrophe castastrophe self-assigned this Sep 19, 2025
@castastrophe castastrophe requested a review from a team as a code owner September 19, 2025 17:34
@castastrophe castastrophe added dependencies Pull requests that update a dependency file Priority ready-for-review labels Sep 19, 2025
Copy link

changeset-bot bot commented Sep 19, 2025

⚠️ No Changeset found

Latest commit: 547e9e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@castastrophe castastrophe force-pushed the castastrophe/chore-pin-dependencies-swc-1243 branch 15 times, most recently from abc653f to bffc460 Compare September 19, 2025 18:58
Comment on lines -63 to -64
"fs": "^0.0.1-security",
"path": "^0.12.7",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to load fs and path; those ship with node

@castastrophe castastrophe force-pushed the castastrophe/chore-pin-dependencies-swc-1243 branch 2 times, most recently from acad835 to fb6f382 Compare September 19, 2025 19:18
"dependencies": {
"@internationalized/number": "^3.6.0",
"@lit-labs/observers": "^2.0.2",
"@internationalized/number": "3.6.5",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The yarn.lock was resolving to 3.6.5 so I updated here to prevent regressions

@castastrophe castastrophe force-pushed the castastrophe/chore-pin-dependencies-swc-1243 branch from fb6f382 to 8ff113f Compare September 19, 2025 19:22
Copy link
Contributor

@blunteshwar blunteshwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this

@castastrophe castastrophe force-pushed the castastrophe/chore-pin-dependencies-swc-1243 branch from 8ff113f to f16380c Compare September 24, 2025 15:38
@castastrophe castastrophe force-pushed the castastrophe/chore-pin-dependencies-swc-1243 branch from f16380c to 5193d74 Compare September 24, 2025 16:18
@castastrophe castastrophe added the skip_lint Skip the linting tasks label Sep 24, 2025
@castastrophe castastrophe force-pushed the castastrophe/chore-pin-dependencies-swc-1243 branch 2 times, most recently from ca65b7b to 5187af8 Compare September 24, 2025 17:14
Copy link
Contributor

github-actions bot commented Sep 24, 2025

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5744

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link
Contributor

Tachometer results

Currently, no packages are changed by this PR...

@castastrophe castastrophe force-pushed the castastrophe/chore-pin-dependencies-swc-1243 branch from 5187af8 to 5a0730a Compare September 24, 2025 17:33
@castastrophe castastrophe enabled auto-merge (squash) September 24, 2025 17:33
@castastrophe castastrophe force-pushed the castastrophe/chore-pin-dependencies-swc-1243 branch from 5a0730a to 74b0df7 Compare September 24, 2025 17:41
@castastrophe castastrophe force-pushed the castastrophe/chore-pin-dependencies-swc-1243 branch from 74b0df7 to 547e9e9 Compare September 24, 2025 17:42
@castastrophe castastrophe merged commit ddad706 into main Sep 24, 2025
24 checks passed
@castastrophe castastrophe deleted the castastrophe/chore-pin-dependencies-swc-1243 branch September 24, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Priority ready-for-review skip_lint Skip the linting tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants