Support for class based validators

[bobisjan]

Hello 👋,

I have question about using class based validators.

The use case is about having validator dependent on a service.

import Validator from 'ember-changeset-validations/validator';
import  { inject as service } from '@ember/service';

export default class PersonalNoValidator extends Validator {
  @service ajax;

  async validate(key, newValue, oldValue, changes, content) {
    try {
      await this.ajax.post('/api/personal-no/validation', { data: newValue });
      return true;
    } catch (_) {
      return 'Personal No is invalid';
    }
  }
}

Would it make sense to support this, or is there a path to solve this currently?

Thanks

[snewcomer]

@bobisjan Great idea. I'm working on getting a few things updated. But we should tackle after that.

[lindyhopchris]

This would be a great addition - and I believe would close #124 as that's effectively asking about injecting the store.

[snewcomer]

Let's tackle after v3 for ember-changeset && major version bump this package to be compatible!

adopted-ember-addons/ember-changeset#379

[basz]

Know that you can do this already if you need to

// app/instance-initializers/container.js
import application from 'utils/application';

export function initialize(appInstance) {
  application.instance = appInstance;
}

export default {
  initialize
};

// app/utils/application.js

export default {
  instance: null
};

// your/validator.js
import application from 'lab-plhw/utils/application';

const myService = application.instance.lookup('service:myService');

[nickschot]

What about class based Validations? Would be useful in cases where i.e. a translated description needs to be provided.

[snewcomer]

Would it make sense to support this, or is there a path to solve this currently?

Lets see if we can get something working this week 👍