[MAJOR]: rewrite for v3

.eslintrc.js

@@ -1,8 +1,12 @@
 module.exports = {
   root: true,
+  parser: 'babel-eslint',
   parserOptions: {
-    ecmaVersion: 2017,
-    sourceType: 'module'
+    ecmaVersion: 2018,
+    sourceType: 'module',
+    ecmaFeatures: {
+      legacyDecorators: true
+    }
   },
   plugins: [
     'ember'
@@ -15,13 +19,14 @@ module.exports = {
     browser: true
   },
   rules: {
-    'ember/avoid-leaking-state-in-ember-objects': 0
+    'ember/no-jquery': 'error'
   },
   overrides: [
     // node files
     {
       files: [
         '.eslintrc.js',
+        '.template-lintrc.js',
         'ember-cli-build.js',
         'index.js',
         'testem.js',
@@ -36,8 +41,7 @@ module.exports = {
         'tests/dummy/app/**'
       ],
       parserOptions: {
-        sourceType: 'script',
-        ecmaVersion: 2015
+        sourceType: 'script'
       },
       env: {
         browser: false,

.npmignore

@@ -8,10 +8,11 @@
 # misc
 /.bowerrc
 /.editorconfig
-/.ember-cli
+/.ember-cli.js
 /.env*
 /.eslintignore
 /.eslintrc.js
+/.git/
 /.gitignore
 /.template-lintrc.js
 /.travis.yml

.travis.yml

@@ -48,8 +48,7 @@ jobs:
     # we recommend new addons test the current and previous LTS
     # as well as latest stable release (bonus points to beta/canary)
     - stage: "Additional Tests"
-      env: EMBER_TRY_SCENARIO=ember-lts-2.18
-    - env: EMBER_TRY_SCENARIO=ember-lts-3.4
+      env: EMBER_TRY_SCENARIO=ember-3.13
     - env: EMBER_TRY_SCENARIO=ember-release
     - env: EMBER_TRY_SCENARIO=ember-beta
     - env: EMBER_TRY_SCENARIO=ember-canary

README.md

@@ -15,7 +15,7 @@ ember install ember-changeset
 
 ## Updates
 
-We have released `v2.0.0`.  This includes a solution for deeply nested sets with one big caveat.  Some history - Post v1.3.0, there was an elegant solution proposed and implemented for deeply nested sets - e.g. `changeset.set('profile.name', 'myname')`.  However, this caused many issues and was reverted in v2.0.0-beta.  Since `ember-changeset` relies on [Proxy](https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Proxy) like behaviour, we are able to trap `changeset.set(...` and properly handle nested sets.  This, however, is a problem in templates where `mut changeset.profile.name` is implicitly `set(changeset, 'profile.name')`, thus subverting our trap.  This is the caveat with the v2.0.0 release.  Although it is an improvement over v1.3.0 and should be 1-1 behaviour if you are setting at a single level - e.g. `mut changeset.name` -, nested setters don't have an ideal solution.  So we are releasing v2.0.0 with this caveat and adding a `changeset-set` template helper.  This is a work in progress.
+We have released `v3.0.0`.  This requires Ember >= 3.13 as the use of `@tracked` will help us monitor and propagate changes to the UI layer.  If your app is < 3.13, the you can install the 2.0 series `ember install [email protected]`.
 
 ## Philosophy
 
@@ -440,11 +440,11 @@ get(changeset, 'momentObj.content').format('dddd'); // => "Friday"
 
 #### `set`
 
-Exactly the same semantics as `Ember.set`. This stores the change on the changeset.
+Exactly the same semantics as `Ember.set`. This stores the change on the changeset. It is recommended to use `changeset.set(...)` instead of `Ember.set(changeset, ...)`.  `Ember.set` will set the property for nested keys on the underlying model.
 
 ```js
-set(changeset, 'firstName', 'Milton'); // "Milton"
-set(changeset, 'address.zipCode', '10001'); // "10001"
+changeset.set('firstName', 'Milton'); // "Milton"
+changeset.set('address.zipCode', '10001'); // "10001"
 ```
 
 You can use and bind this property in the template:
@@ -879,7 +879,7 @@ export default Component.extend({
     let snapshot = changeset.snapshot();
 
     // valuePath is the property on the changeset, e.g. firstName
-    set(changeset, valuePath, value);
+    changeset.set(valuePath, value);
 
     if (!changeset.get(`error.${valuePath}`)) {
       set(this, 'hasError', false);
@@ -898,7 +898,7 @@ export default Component.extend({
      * @param {Object} e
      */
     validateProperty(changeset, valuePath, e) {
-      set(changeset, valuePath, e.target.value);
+      changeset.set(valuePath, e.target.value);
 
       if (changeset.get(`error.${valuePath}`)) {
         set(this, 'hasError', true);

addon/-private/evented.ts

@@ -0,0 +1,15 @@
+import Notifier from './notifier';
+
+export function notifierForEvent(object: any, eventName: string) {
+  if (object._eventedNotifiers === undefined) {
+    object._eventedNotifiers = {};
+  }
+
+  let notifier = object._eventedNotifiers[eventName];
+
+  if (!notifier) {
+    notifier = object._eventedNotifiers[eventName] = new Notifier();
+  }
+
+  return notifier;
+}

addon/-private/notifier.ts

@@ -0,0 +1,27 @@
+// this statefull class holds and notifies
+
+export default class Notifier<T extends any[]>{
+  listeners: ((...args: T) => void)[]
+
+  constructor() {
+    this.listeners = [];
+  }
+
+  addListener(callback: (...args: T) => void) {
+    this.listeners.push(callback);
+    return () => this.removeListener(callback);
+  }
+
+  removeListener(callback: (...args: T) => void) {
+    for (let i = 0; i < this.listeners.length; i++) {
+      if (this.listeners[i] === callback) {
+        this.listeners.splice(i, 1);
+        return;
+      }
+    }
+  }
+
+  trigger(...args: T) {
+    this.listeners.forEach(callback => callback(...args));
+  }
+}