Update AIX scripts #118

jdekonin · 2018-01-08T17:17:19Z

Signed-off-by: Joe deKoning [email protected]

bblondin · 2018-01-08T18:06:38Z

ansible/playbooks/aix.yml

@@ -34,7 +34,7 @@
    ################################
    - name: Download AIX filesystem configuration script
      get_url:
-        url: https://github.com/raw/AdoptOpenJDK/openjdk-infrastructure/master/ansible/playbooks/scripts/AIX_filesystem_config.sh
+        url: https://github.com/raw/jdekonin/openjdk-infrastructure/master/ansible/playbooks/scripts/AIX_filesystem_config.sh


Why are we pointing to your username?

Its the only way I could test, this would need to be changed prior to commit.

I have tested against my own fork and this works only on the 7.1.4 distro as there are version specific rpms. Thats a future todo, if/when further versions are required.

I also encountered an issue with installing/upgrading the zlib rpm. The version (1.2.11-1.aix5.1) commented out is required for openjdk to build, but that version breaks python. My current answer for that is it needs to be performed manually. Not ideal, but then at least the rest of the system setup can be performed via ansible.

sxa · 2018-01-15T14:33:45Z

ansible/playbooks/scripts/AIX_RPM_PKGs_Install.sh

+rpm -Uvh bash-4.4-3.aix6.1.ppc.rpm
+
+wget http://www.bullfreeware.com/download/bin/3517/libgcc-6.3.0-1.aix7.1.ppc.rpm
+rpm -Uvh libgcc-6.3.0-1.aix7.1.ppc.rpm


This failed for me because AIX-rpm saying:
AIX-rpm < 7.2.0.0. is needed by libgcc-6.3.0.1
I have AIX-rpm-7.2.0.1-1 on my system.

Once I have the yum method functioning 100%, which I have very close, this will not be an issue.

sxa · 2018-01-15T14:49:03Z

Is there a reason not to use rpm -Uvh directly with the wget/ftp URLs instead of just giving the URL to rpm? I could understand if we were caching the RPMs in case the playboks but the way it's set up just now there's no checking fo the .rpm files' presence so it'll re-download if you run the script.

jdekonin · 2018-01-15T17:28:42Z

I actually didn't know it could be done that way until recently, I just hadn't updated the script. I am testing the yum/AIX toolbox method we were discussing via slack. If that works better I am fine with switching to that method.

sxa · 2018-01-15T14:34:14Z

ansible/playbooks/scripts/AIX_RPM_PKGs_Install.sh

+wget http://www.bullfreeware.com/download/bin/2536/autoconf-2.69-2.aix6.1.noarch.rpm
+rpm -Uvh autoconf-2.69-2.aix6.1.noarch.rpm
+
+wget http://www.bullfreeware.com/download/bin/3544/vim-common-7.4-2.aix6.1.ppc.rpm


What's the reason for installing vim here? Surely it's not a required dependency on a build/test machine?

vi on aix is not user friendly imo, adding vim was simply for the admin. Its not a requirement for a build/test machine.

sxa · 2018-01-15T14:47:13Z

ansible/playbooks/scripts/AIX_RPM_PKGs_Install.sh

+rpm -Uvh m4-1.4.17-1.aix6.1.ppc.rpm
+
+wget http://www.bullfreeware.com/download/bin/3555/gettext-0.19.8-1.aix6.1.ppc.rpm
+rpm -Uvh --nodeps gettext-0.19.8-1.aix6.1.ppc.rpm


This appears to depend on ncurses which is not installed until later

(Comment likely irrelevant with the switch to yum)

sxa · 2018-01-15T14:53:54Z

ansible/playbooks/aix.yml

-    - name: Create rpm tmp folder /tmp/playbook_tmp/rpms
-      file: path=/tmp/playbook_tmp/rpms state=directory mode=0755
+    - name: Create rpm tmp folder /tmp/playbook_tmp/pkgs
+      file: path=/tmp/playbook_tmp/pkgs state=directory mode=0755
      tags: layout


Would this not be better done in the IX_RPM_PKGs_Install.sh script to allow it to be used standalone? There's currently no error checking in the script so if the directory does not exist it's going to wherever it happens to be.

Agreed, I'll be reworking this section and other with checks to permit ansible tower execution more than once and not having the machine left in an unusable state.

jdekonin · 2018-01-31T16:45:13Z

ansible/playbooks/aix.yml

+
+    - shell: tar -xvf /tmp/openssl-1.0.2.1300.tar -C /tmp/
+      tags: openssl
+


The previous 3 steps could be done in one "unarchive", like I do in other spots in the file, but there is no unzip installed by default, and its not installed until the yum step(s).

Not sure why unzip is relevant here: This should do it for the last two steps at least: gzip -cd /tmp/openssl-1.0.2.1300.tar.gz | tar xf - -C /tmp/

The unarchive method can transfer the file and unpack in one step instead of 3 (or 2 with your proposed change) but it depends on unzip. I was simply meaning that I couldn't use the ansible preferred method as the warning when you run it in AWS states "Consider using unarchive module rather than running tar". I simplified with your suggestion.

jdekonin · 2018-01-31T17:08:59Z

I believe this is ready for review. I have this working via ansible tower on AIX releases :

7.1.3.[5|9]
7.1.4.[3|4]
7.2.0.[2|4]
7.2.1.[3|4]

bblondin · 2018-01-31T17:42:06Z

ansible/playbooks/aix.yml

+
+    - debug:
+        msg: "Yum installed, skipping download and installation"
+      when: yum.stat.islnk is defined


when: yum.stat.islnk is defined

Is yum a symlink?

islnk | Tells you if the path is a symbolic link | success, path exists and user can read stats | boolean | False

Should it be yum.stat.exists == True

Technically, stat is on /usr/bin/yum which is a link to /opt/freeware/bin/yum, both of which are added with the yum.sh 'install'.

I think the method is valid, but I could also change to exists method if you feel strongly about it.

no, that's fine just wanted to confirm

bblondin · 2018-01-31T17:44:26Z

ansible/playbooks/aix.yml

+      when: yum.stat.islnk is not defined
+      tags: yum
+
+    - name: Ensure the yum package index is up to date


This set of commands will update everything to latest not just updating the cache so, I think the title here should be changed

Update made.

bblondin · 2018-01-31T17:47:43Z

ansible/playbooks/aix.yml

+
+  ################
+  # Pass or Fail #
+  ################


The Slack section here can be removed

Update made.

bblondin

Looks good to me. (next we'll want to reformat it to the newer style layout, but that can be done later)

* filesystem setup for jenkins user in /home * add checks prior to performing task to speed update * replace most all rpm installs with the yum installer Signed-off-by: Joe deKoning <[email protected]>

jdekonin · 2018-01-31T20:34:32Z

I believe I have commented and/or updated to all responses.

gdams · 2018-02-02T22:24:36Z

does this cover the creation of ramdisks? #44

jdekonin · 2018-02-06T18:32:30Z

No it does not. Those changes were not made in the previous version. I'd suggest a follow on issue for adding that functionality.

gdams · 2018-02-06T22:11:52Z

Can someone create a follow up issue for adding ramdisk?

jdekonin requested a review from bblondin January 8, 2018 17:17

karianna added the enhancement label Jan 8, 2018

bblondin reviewed Jan 8, 2018

View reviewed changes

sxa reviewed Jan 15, 2018

View reviewed changes

sxa reviewed Jan 16, 2018

View reviewed changes

jdekonin force-pushed the master branch 13 times, most recently from b18bae2 to f0d96df Compare January 31, 2018 16:42

jdekonin commented Jan 31, 2018

View reviewed changes

jdekonin force-pushed the master branch from f0d96df to b693709 Compare January 31, 2018 17:02

jdekonin changed the title ~~WIP: Update AIX scripts~~ Update AIX scripts Jan 31, 2018

bblondin reviewed Jan 31, 2018

View reviewed changes

jdekonin force-pushed the master branch from b693709 to ac4b299 Compare January 31, 2018 18:19

bblondin approved these changes Jan 31, 2018

View reviewed changes

Update AIX scripts

45468d9

* filesystem setup for jenkins user in /home * add checks prior to performing task to speed update * replace most all rpm installs with the yum installer Signed-off-by: Joe deKoning <[email protected]>

jdekonin force-pushed the master branch from ac4b299 to 45468d9 Compare January 31, 2018 20:33

bblondin merged commit 96ac528 into adoptium:master Feb 6, 2018

karianna mentioned this pull request Feb 7, 2018

Add Ramdisk configuration to AIX ansible scripts #182

Closed

jdekonin mentioned this pull request Aug 30, 2019

Failure to build native tests on AIX #921

Closed


		- shell: tar -xvf /tmp/openssl-1.0.2.1300.tar -C /tmp/
		tags: openssl

Uh oh!

Update AIX scripts #118

Update AIX scripts #118

Uh oh!

Conversation

jdekonin commented Jan 8, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sxa commented Jan 15, 2018

Uh oh!

jdekonin commented Jan 15, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdekonin Jan 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdekonin commented Jan 31, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bblondin left a comment

Choose a reason for hiding this comment

Uh oh!

jdekonin commented Jan 31, 2018

Uh oh!

gdams commented Feb 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jdekonin commented Feb 6, 2018

Uh oh!

gdams commented Feb 6, 2018

Uh oh!

Uh oh!

jdekonin Jan 31, 2018 •

edited

Loading

gdams commented Feb 2, 2018 •

edited

Loading