Skip to content

[ENH] Series search for similarity search module #2010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

baraline
Copy link
Member

@baraline baraline commented Aug 25, 2024

Reference Issues/PRs

Fixes #1900

What does this implement/fix? Explain your changes.

After the query search, this PR introduces the series search, which is linked to the task of computing matrix profiles.
To make this task compatible with query search (for the naive approach), I changed the return of the predict function for query search to return both index and distances to best matches.
Modified docstrings accordingly.

For now, only the naive version (the one looping on query search, which is equivalent to STAMP from matrix profile paper 1) and STOMP (from matrix profile paper 2) algorithm for squared and euclidean distance are implemented. I'll add the different matrix profiles (e.g. SWAMP with dtw and more efficient euclidean ones) methods in a later PR.

Minimal functionality were tested given time frame for ECML, more complete test are planned in next PR.

Comments

I'm still not entirely satisfied with the naming of query search / series search, so that's open to discussion

PR checklist

For all contributions
  • I've added myself to the list of contributors. Alternatively, you can use the @all-contributors bot to do this for you.
  • The PR title starts with either [ENH], [MNT], [DOC], [BUG], [REF], [DEP] or [GOV] indicating whether the PR topic is related to enhancement, maintenance, documentation, bugs, refactoring, deprecation or governance.
For new estimators and functions
  • I've added the estimator to the online API documentation.
  • (OPTIONAL) I've added myself as a __maintainer__ at the top of relevant files and want to be contacted regarding its maintenance. Unmaintained files may be removed. This is for the full file, and you should not add yourself if you are just making minor changes or do not want to help maintain its contents.
For developers with write access
  • (OPTIONAL) I've updated aeon's CODEOWNERS to receive notifications about future changes to these files.

@baraline baraline linked an issue Aug 25, 2024 that may be closed by this pull request
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@aeon-actions-bot aeon-actions-bot bot added enhancement New feature, improvement request or other non-bug code enhancement examples Example notebook related similarity search Similarity search package visualisation Visualisation module labels Aug 25, 2024
@aeon-actions-bot
Copy link
Contributor

aeon-actions-bot bot commented Aug 25, 2024

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#45FD64}{\textsf{examples}}$, $\color{#006b75}{\textsf{similarity search}}$, $\color{#FBCA04}{\textsf{visualisation}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Push an empty commit to re-run CI checks

@aeon-actions-bot aeon-actions-bot bot added the codecov actions Run the codecov action on a PR label Aug 26, 2024
@baraline baraline removed the visualisation Visualisation module label Aug 28, 2024
@baraline
Copy link
Member Author

baraline commented Sep 1, 2024

Will update notebooks tomorrow and this will be good for review ! (and fix test that fails while I'll sleep)

@baraline baraline removed the codecov actions Run the codecov action on a PR label Sep 2, 2024
@baraline baraline marked this pull request as ready for review September 2, 2024 16:53
@baraline baraline marked this pull request as draft September 3, 2024 12:56
@baraline
Copy link
Member Author

baraline commented Sep 3, 2024

Switching this back to draft as there is huge performance issue with STOMP

@baraline baraline marked this pull request as ready for review September 3, 2024 15:32
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to approve the module changes in this given the upcoming ECML tutorial, the fact the module is experimental and the next release after this is v1.0.0 with major changes.

We should have a more thorough review prior to v1.0.0 I feel, however.

Couple of comments for other changes though.

@baraline
Copy link
Member Author

baraline commented Sep 7, 2024

I agree that some changes would be needed before 1.0 to make thing cleaner, multiple issues are already up for this purpose.

@MatthewMiddlehurst MatthewMiddlehurst merged commit 9a0b787 into main Sep 7, 2024
14 checks passed
@MatthewMiddlehurst MatthewMiddlehurst deleted the 1900-enh-series-search-for-similarity-search-module branch September 7, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement examples Example notebook related similarity search Similarity search package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Series search for similarity search module
2 participants