Skip to content

Rename preorder reasoning syntax #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MatthewDaggitt opened this issue Oct 13, 2023 · 6 comments · Fixed by #2156
Closed

Rename preorder reasoning syntax #2145

MatthewDaggitt opened this issue Oct 13, 2023 · 6 comments · Fixed by #2156
Assignees
@MatthewDaggitt
Labels
deprecation
Milestone
v2.0

Comments

@MatthewDaggitt
Copy link
Contributor

#2099 didn't change the name of the reasoning combinators in Relation.Binary.Reasoning.Preorder
@MatthewDaggitt MatthewDaggitt added this to the v2.0 milestone Oct 13, 2023
@MatthewDaggitt MatthewDaggitt self-assigned this Oct 13, 2023
@MatthewDaggitt MatthewDaggitt mentioned this issue Oct 13, 2023
Closed
@jamesmckinna
Copy link
Contributor

I see you've self-assigned; probably quicker if you do it, but let me know if you'd rather someone else... but not entirely clear how it interacts/would interact with your design for #2146 ?

@MatthewDaggitt
Copy link
Contributor Author

but not entirely clear how it interacts/would interact with your design for #2146 ?

Will fix this issue once the redesign has been merged in.

@MatthewDaggitt MatthewDaggitt added the status: blocked-by-issue Progress on this issue or PR is blocked by another issue. label Oct 13, 2023
@MatthewDaggitt
Copy link
Contributor Author

Also missed was Preorder.∼-respˡ-≈ and friends.

@jamesmckinna
Copy link
Contributor

Did you ever figure out an asnwer to my query about (failure of the) deprecation warning #2099 (comment) in Relation.Unary.Closure.Preorder?

@MatthewDaggitt
Copy link
Contributor Author

Ah sorry, missed that comment. Yes it's an instance of agda/agda#5617

@jamesmckinna
Copy link
Contributor

Still, annoying-but-still-safe is an OK status quo, for the time being at least.

@MatthewDaggitt MatthewDaggitt mentioned this issue Oct 16, 2023
Merged
@jamesmckinna jamesmckinna removed the status: blocked-by-issue Progress on this issue or PR is blocked by another issue. label Oct 16, 2023
MatthewDaggitt added a commit that referenced this issue Oct 16, 2023
@MatthewDaggitt
Fix missing deprecating warning from #2145
2a21bf3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MatthewDaggitt MatthewDaggitt

Labels
deprecation
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

Rename preorder ~ relation reasoning combinators agda/agda-stdlib
2 participants
@MatthewDaggitt @jamesmckinna