Skip to content

Update Function.Endomorphism.* to avoid use of deprecated Function.Equality #2299

Closed
@jamesmckinna

Description

@jamesmckinna

The #759 deprecation effort left some residues which still import (at least) Function.Equality (with a pragma to suppress the warning), notably:

  • Function.Endomorphism.Setoid
    Function.Endomorphism.Propositional

which define the monoid etc. of endomorphisms (needed for a development of Foldable cf. generalising #1281 , and also now #2350 ).

UPDATED: blocked on not-yet-merged #2240 each of the above also uses the long-since-deprecated (v1.5!) Algebra.Morphism.Is*Morphism definitions instead of updating to the ones in Algebra.Morphism.Structures ...

Should update to remove dependency on the deprecated module(s).

Activity

JacquesCarette

JacquesCarette commented on Apr 24, 2024

@JacquesCarette
Contributor

Unfortunately the PR itself is regarded as a breaking change (even though not doing this for v2.0 was an oversight), so this issue should also get that label.

jamesmckinna

jamesmckinna commented on May 15, 2024

@jamesmckinna
ContributorAuthor

So the non-breaking suggestion on #2342 would be (instead) to introduce Function.Endo.* as new modules, and deprecate the Function.Endomorphism.* modules...?

JacquesCarette

JacquesCarette commented on May 16, 2024

@JacquesCarette
Contributor

Yes, I think that that name makes more sense than .New. I'll implement that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @JacquesCarette@jamesmckinna

    Issue actions

      Update `Function.Endomorphism.*` to avoid use of deprecated `Function.Equality` · Issue #2299 · agda/agda-stdlib