Skip to content

Deprecate pos-distrib-* in favour of pos-*-commute? #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gallais opened this issue Oct 17, 2018 · 3 comments · Fixed by #1835
Closed

Deprecate pos-distrib-* in favour of pos-*-commute? #501

gallais opened this issue Oct 17, 2018 · 3 comments · Fixed by #1835

Comments

@gallais
Copy link
Member

gallais commented Oct 17, 2018

In Data.Integer.Properties,

pos-distrib-* :  x y  (+ x) * (+ y) ≡ + (x ℕ* y)

is the symmetric of the not yet existing function

pos-*-commute : ℕtoℤ.Homomorphic₂ +_ _ℕ*_ _*_

where module ℕtoℤ = Morphism.Definitions ℕ ℤ _≡_.

Names based on the existing function

abs-*-commute : ℤtoℕ.Homomorphic₂ ∣_∣ _*_ _ℕ*_

where module ℤtoℕ = Morphism.Definitions ℤ ℕ _≡_

@mechvel
Copy link
Contributor

mechvel commented Mar 27, 2021

I vote for the suggestion by @gallais.
Also pos-*-commute do exist in lib-1.5.
Also even if it is pos-distrib-* then at least the equality parts in the signature need to be swapped.

@MatthewDaggitt MatthewDaggitt added this to the v2.0 milestone Jul 11, 2021
@jamesmckinna
Copy link
Contributor

But what about the general injunction against spurious additional -commute suffixes, as per issue #509 ?

@JacquesCarette
Copy link
Contributor

So pos-* and abs-* ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants