Fixity #1228
Merged
Fixity #1228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! I particularly like the README file 👍 You're going to hate me for this, but each of these probably need a changelog entry (particularly as these are breaking changes). You could put them under the "Bug" section. |
|
Oh my, CHANGELOG entries. That does increase the workload too. Oh well, I'll work on plowing through that as well. |
|
❤️ |
Apologies... You could add them in for these changes, and then I can merge this lot in as is. That way you don't have to do the whole thing in one go? |
|
That was my plan, otherwise there's just too much. I just haven't had the time to circle back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tiny part of issue #207 (about 15% of the missing cases done).