Skip to content

Fix missing fixities in some files (#207) #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Conversation

yxdai-nju
Copy link
Contributor

For infixr 6 _<∣>_ in /Data/Maybe/Base.agda

_<∣>_ : Maybe A → Maybe A → Maybe A
just x  <∣> my = just x
nothing <∣> my = my

_<∣>_ should be right associative, similar to Data.Sum._⊎_,

case₁ : ∀ (x y : Maybe A) → x <∣> y <∣> nothing ≡ x <∣> y
case₁ (just x) y = refl
case₁ nothing (just y) = refl
case₁ nothing nothing = refl

and since _<∣>_ cannot connect List's (e.g. just 1 ∷ [] <∣> nothing ∷ []), it is safe to give it a precedence greater than 5 to make the following case possible without parentheses.

case₂ : List (Maybe ℕ)
case₂ = just 1 <∣> nothing ∷ []

For infixl 0 _!|>_ in /Function/Strict.agda

Looks like the first _!|>′_ is a misspelling of _!|>_.

infixl 0 _!|>′_ _!|>′_

@MatthewDaggitt
Copy link
Contributor

Thanks for the PR! Looks great, except that you've added the CHANGELOG entry to v1.7 which has already been released. Please could move the entry to the current CHANGELOG.md at the top-level of the directory?

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
@yxdai-nju
Copy link
Contributor Author

except that you've added the CHANGELOG entry to v1.7 which has already been released

Sorry, I didn't notice! I have moved the entry to the current CHANGELOG.md in the updated commits.

@MatthewDaggitt
Copy link
Contributor

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants