Skip to content

[Import] Reflection #2643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025
Merged

[Import] Reflection #2643

merged 2 commits into from
Mar 17, 2025

Conversation

jmougeot
Copy link
Contributor

@jmougeot jmougeot commented Mar 5, 2025

No description provided.

@JacquesCarette
Copy link
Contributor

Strictly speaking, I personally like lining up the using. But it is not done consistently through the library (or even inside single files), so I'm okay with removing it. Others might not agree.

@jamesmckinna
Copy link
Contributor

Strictly speaking, I personally like lining up the using. But it is not done consistently through the library (or even inside single files), so I'm okay with removing it. Others might not agree.

I think the most robust way to 'preserve' the alignment is to lay off using directives on new lines?
Others have observed that the alignment (on the same line) is not, in general, going to be/stay robust...

@jamesmckinna jamesmckinna changed the title Import] Reflecion [Import] Reflection Mar 7, 2025
@jmougeot jmougeot requested a review from JacquesCarette March 13, 2025 18:29
@jamesmckinna jamesmckinna added this pull request to the merge queue Mar 17, 2025
Merged via the queue into agda:master with commit 185a4ee Mar 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants